search

krogenth / G2DataGUI

A tool for modifying the Anniversary/HD Remaster of Grandia 2.
MIT License
4 stars 5 forks source link

Update ENEMY_MOVES_NORMAL.CSV #5

Closed Guernouille closed 2 years ago

Guernouille commented 2 years ago

Normal / Special Attack Flag 00 - Special Attack: stop time during move execution, and display its name 01 - Normal Attack, time continues during move execution, do not display its name I'm not entirely sure how to name this flag. If you have better name ideas, do not hesitate to modify this commit.

krogenth commented 2 years ago

Hey, thanks for the PR! As you describe, this does seem to be a flag to specify if that enemy move is a normal attack or not. The only caveat I can see is for normal attacks, setting this flag to be a non-normal attack will soft-lock the game after the enemy completes the attack. I also checked against the MS_PARAM's last unknown value, but that does not appear to function similarly.

I think the naming is acceptable, but the docs/ENEMY_MOVES_HARDMODE.CSV, src/include/EnemiesClass.h, and src/EnemiesClass.cpp should be adjusted to reflect this change as well. I can handle this if necessary.

Guernouille commented 2 years ago

I will take care of this as soon as I get back home :)

Guernouille commented 2 years ago

See https://github.com/krogenth/G2DataGUI/pull/8