Support annotation array detection

[samskiter]

Im trying to loop over repeated annotations, except sometimes they might not be repeated.

How can I treat the annotation as an array even if it's only a single value?

[ilyapuchka]

Annotations are stored as a dictionary so you can access them by their name. In Stencil you can iterate over dictionary now, using swift templates it's just normal iteration over dictionary.

[samskiter]

Thanks for the fast reply @ilyapuchka - unfortunately don't seem to be able to get that working:

{% for type in types.protocols|annotated:"TypeErase" %}

{% for key, value in type.annotations %}{{ key }}{% endfor %}

{% endfor %}

This crashes with Note:'for' statements should use the following 'for x in y' 'for key, value in type.annotations'.

Running 0.6.0:

./Pods/Sourcery/bin/sourcery --version
0.6.0

[ilyapuchka]

And what is the crash?

[samskiter]

Whoops you beat me to it, was just updating my comment ^^

[ilyapuchka]

We didn't release a new version with Stencil 0.9.0 yet, so you need to use latest master version - CHANGELOG

[samskiter]

aha ok, thanks, i will try pointing my pod repo to you 👍

[samskiter]

@ilyapuchka Looks like your podspec doesn't work out of the box either. i'll see if I can work out how to fix it

[ilyapuchka]

CocoaPods will download latest release, so you should build from source code.

[samskiter]

@ilyapuchka you can use cocoapods to point to a git repo+sha right? I'm using pod 'Sourcery', :git => 'https://github.com/krzysztofzablocki/Sourcery.git', :commit => 'a6118efb5b9756eb59570e5e92b625c9b591fd24'

[samskiter]

Ahh i see, you pull from releases

[samskiter]

@ilyapuchka Have tried building from master, used the rake scripts to generate a new zip, then pointed to that locally using cocoapods. Getting a slightly different error message now:

error: /Users/samduke/Waking-iOS/scripts/Sourcery/Templates/TypeErase.stencil: 'for' statements should use the following 'for x in y where condition' `for key, value in type.annotations`.

It's now outputting as an error and there is some information about where conditions, so I'm certain I have a different build from your last release

[samskiter]

@ilyapuchka I got it working by iterating like so:

{% for type in types.protocols|annotated:"TypeErase" %}

{% for key,value in type.annotations %}{{ key }}{% endfor %}

{% endfor %}

But I still get an array for the dictionary values where "TypeErase" is a key

So I'm back to square one.

So for a file like this:

// sourcery: TypeErase = a
protocol bar {
associatedtype a
}

and a file like this:

// sourcery: TypeErase = a
// sourcery: TypeErase = b
protocol foo {
associatedtype a
associatedtype b
}

I'd like to be able to generate something like this

struct barStruct<a> {
}
struct fooStruct<a, b> {
}

[samskiter]

Hey again @ilyapuchka - I also brought this up on SwiftStencilKit here: https://github.com/SwiftGen/StencilSwiftKit/issues/44 and they suggested it might be best to always return an array for each annotation name...

[ilyapuchka]

Can you use macro node or swift templates as advised in #307?

[bolismauro]

@ilyapuchka @samskiter I decided to keep the ugly stencil I need to have rather than using swift. This is because the generation time is considerably higher than stencil

[Antondomashnev]

hey suggested it might be best to always return an array for each annotation name

@ilyapuchka @bolismauro I, actually, agree with that. I think it's confusing when the same code returns different type of object under different circumstances.

[samskiter]

I think that would be great. the only other useful thing to do would be either to define dictionaries through annotations or in some way allow splitting by a string (e.g. ',')

[Antondomashnev]

@samskiter you can take a look on #313, they're some proposals that could improve annotations 😄

[haimwaking]

I've run into this issue today, is there a resolution for this?

[Antondomashnev]

Hey @haimwaking @samskiter check out the https://github.com/krzysztofzablocki/Sourcery/pull/425

In the next Sourcery release you'll be able to use toArray filter to convert any value into array.

[haimwaking]

Cheers for that, looking forward!