search

kshawkin / Best-Practices-for-TEI-in-Libraries

Best Practices for TEI in Libraries: A guide for mass digitization, automated workflows, and promotion of interoperability with XML using the TEI
http://purl.oclc.org/NET/teiinlibraries
32 stars 8 forks source link

merge bibliographic changes #59

Closed emylonas closed 7 years ago

kshawkin commented 7 years ago

Comments on Syd's comments ...

a) Regarding https://github.com/kshawkin/Best-Practices-for-TEI-in-Libraries/commit/b4bb36a9ff6b0b1260b68351f461d68a282a3068 , let's improve “XInclude or URI references”.

b) Regarding https://github.com/kshawkin/Best-Practices-for-TEI-in-Libraries/commit/72250385dafc8a57c178c15dc6e7277204572c26 , you're right that both render the same, but we had a brief discussion about which is canonical and decided to change.

c) Regarding https://github.com/kshawkin/Best-Practices-for-TEI-in-Libraries/commit/8755b076e9cc7ab7a1427ba2a237faa7427f8988 , which value are you talking about?

d) Regarding https://github.com/kshawkin/Best-Practices-for-TEI-in-Libraries/commit/e1607603903cff7091baae79bc0edf480153b7ee , I see a lot of unrelated changes, but I can't imagine that they're all in error ...

emylonas commented 7 years ago

a) b4bb36a belongs to #16. had made some improvements, could use more.

b) agree with @kshawkin - the second is more canonical

c) this is likely in progress

d) I think this may come from a merge - most of the changes aren't mine.

emylonas commented 6 years ago

all fixed but don't understand this comment Approving 8755b07, but we should add phrase-level encoding for the value. @sydb it's from above.

kshawkin commented 6 years ago

For the record, Elli said on 2018-02-13 that she and Syd sorted out the thing that confused them while solving another problem.