ksucpea / bettercanvas

Dark mode, better todo list, GPA calculator, and more for Canvas
MIT License
89 stars 23 forks source link

js issue for specifically my school's canvas #15

Open Solenyy27 opened 1 year ago

Solenyy27 commented 1 year ago

Hi, coding noob here. My school's version of canvas doesn't have canvas actually written in the domain (webcourses.ucf.edu) so the function that checks to see if the page displayed is a canvas page doesn't work for me. I manually forked, downloded, changed, verified, and installed a modified version of this with just that field changed and it works fine now.

Also the column that has the home, modules, etc. tabs is still blaringly white for me, I think ic-Layout-columns needs to be included somewhere but, as meantioned, I'm new to this and couldn't get it to work.

ksucpea commented 1 year ago

Did you try putting in a custom url into the menu before changing the code? Also could you leave a screenshot of the inspect element for the white portion, mine doesn't show as white so I can't find it, thanks.

Solenyy27 commented 1 year ago

yep, tried chainging the custom url but either I'm just dumb or it didn't work for me. image

ksucpea commented 1 year ago

Ok cool I'll see if I can fix that white element. What url are you using for the custom url? I think everyone who has had an issue with it had a trailing slash at the end which was causing the error. If that's not your problem, try typing https:// into the custom url and let me know if that still doesn't work

Solenyy27 commented 1 year ago

ah yup, trailing slash did it lol. White element still there on the non-altered version. Thanks, this is a great lil plugin and it was fun to poke through the code.

ksucpea commented 1 year ago

Great, I will add the white element fix in the next update and we'll see if it works for you

ksucpea commented 1 year ago

Update was published today, can you let me know if it fixed this?

probablypablito commented 1 year ago

I'm facing a similar issue, although it might be due to my language setting. Dark mode is completely broken and I don't see any of the other features working.

[Edit] Language is not the issue.

image

ksucpea commented 1 year ago

Most of the features available require you to be in the card view not the list view like you are, but I’m not sure why the dark mode is broken like that. Do you know how to inspect element and find the white parts? If you can, send a screenshot of the inspect element or if you don’t I can tell you how to. Thanks

probablypablito commented 1 year ago

Card view seems to have fixed the issue not showing. This is great!

I don't mind the dark mode too much. I can inspect element whatever you want but I'm not sure which white part to select :P

I can send you a downloaded version of my page if you'd like, but I'd like it to be kept private for privacy concerns.

ksucpea commented 1 year ago

Awesome, maybe screenshot like 2 or 3 of the white elements so I can see if I can spot an issue

ksucpea commented 1 year ago

If you don’t know which elements are the white ones just right click in the general area of the white element and inspect it and try to find an element that has background-color: #fff or something similar as one of the styles

probablypablito commented 1 year ago

I'd rather send the HTML, I just finished a project involving heavy JS / inspect elementing and do not want to use it any more. Let me know a good way to contact you. You can email me at github [AT] pablito.tech

ksucpea commented 1 year ago

Alright, you can email me ksucpea@gmail.com