ksucpea / bettercanvas

Dark mode, better todo list, GPA calculator, and more for Canvas
MIT License
89 stars 23 forks source link

Improved Todo list does not respect language time format #19

Closed jojo2357 closed 1 year ago

jojo2357 commented 1 year ago

I have English (UK) set for my canvas specifically to have 24-hour time, and the improved todo tab does not respect this

As seen from todo: image

As seen from assignment: image

Also, the ability to set 24 hour time independently of language would be huge.

ksucpea commented 1 year ago

Thanks for bringing this up, I never even thought about this. I'll look into implementing it later today.

ksucpea commented 1 year ago

Alright, I added an option to enable 24 hr format in the menu. I will post the update within the next few days probably. Thanks for the suggestion

jojo2357 commented 1 year ago

I use firefox, could that branch get the update too?

ksucpea commented 1 year ago

Yeah I can do that, I just need to fix some things first for both versions. The Firefox version will probably be updated today anyway because their reviews are almost instant, but chrome takes a bit.

jojo2357 commented 1 year ago

Also, would it be possible to set a global time format (without changing the language?) Looking at the commits seems plausible, but the todo list is created by the plugin whereas the others are not which can be problematic.

Thanks for the quick fixes :)

ksucpea commented 1 year ago

I think I could add this, but I'm not exactly sure how I'd do it. Do you mean like scan the page for dates and change am/pm to 24hr format?

jojo2357 commented 1 year ago

image

It looks plausible to find these tags and change them. I dont see an attached event listening to format changing unfortunately. Still looks very parse-able in this example

jojo2357 commented 1 year ago

Nevermind, that was just a single example. on my assignments tab, there is a different strategy image

ksucpea commented 1 year ago

I will see what I can do but I probably won't be adding that feature if you can change the language to get the 24hr time instead. Also the update is out on Firefox, you'll probably have to press the check for updates button in the addons menu to get the update. Let me know if you have any issues with it, thanks