ksucpea / bettercanvas

Dark mode, better todo list, GPA calculator, and more for Canvas
MIT License
86 stars 23 forks source link

Dashboard Grades #22

Open BGHDDevelopment opened 1 year ago

BGHDDevelopment commented 1 year ago

Hey!

Dashboard grades seem to be glitched on my end again. They only seem to appear for classes that do not have posted grades

chrome_rI2HqXEjYw

For classes that do have grades the overlay does not appear at all:

chrome_1aPEpQ25rb
ksucpea commented 1 year ago

Hey there, sorry I'm responding so late. Any chance you have more than 10 classes on your dashboard?

BGHDDevelopment commented 1 year ago

All good. There are 8 active pinned classes on the dashboard. In terms of in the class list and not pinned, my school does not remove them so over 30.

ksucpea commented 1 year ago

I think right now it only get 10 classes at a time so that could be why. I'll change it to get more classes in the next update and we'll see if that works

BGHDDevelopment commented 1 year ago

Sounds good. Is there any debug mode that I can activate to see in console what it's pulling? Would be helpful for any future debugging.

ksucpea commented 1 year ago

If you go into the devtools under the network tab there should be a fetch request for "api/v1/courses?enrollment_state=active&include[]=total_scores&include[]=current_grading_period_scores", if you can find this you can preview the data its getting and see the classes it's getting grades for, can you check to see if it's getting the right classes? here's what it should look like

BGHDDevelopment commented 1 year ago

Nope pulling courses that are not pinned. I would think if there is a way to just grab stars/pinned classes that would work best to fix the overall issue. At least my school's system automatically adds/removes pins dependent on your active classes.

ksucpea commented 1 year ago

I agree, that would be better. I specified that the enrollment_state is active but maybe theres a different state I can try. If not I'll just get more classes

BGHDDevelopment commented 1 year ago

Is there any downside to just pulling any class with the active status? Rather than containing it at all?

ksucpea commented 1 year ago

Not sure what you mean, like in terms of efficiency if I left that part out?

BGHDDevelopment commented 1 year ago

Yep, like rather than just using limits at all, is there a downside to just pulling every single class in a user's canvas? Or just make it a advanced setting on how many should be pulled.

ksucpea commented 1 year ago

Hi again, didn't see your other comment, but I just updated it for Firefox, Chrome will be out in a day or two. Pretty sure I fixed the issue by just getting more classes, but let me know if you still have problems

BGHDDevelopment commented 1 year ago

Just tested it, seems to grab the majority now still missing a few more though. It may just be due to how my university refuses to remove old courses from the active list.

ksucpea commented 1 year ago

Dang, well I'll see if I can find a different way. The limit is now set to 30 courses but I think I could make it even more if I can't find anything