search

ksucpea / bettercanvas

Dark mode, better todo list, GPA calculator, and more for Canvas
MIT License
103 stars 29 forks source link

Added color overlay toggle for dashboard cards #27

Closed tibogeeraerts closed 1 year ago

tibogeeraerts commented 1 year ago

When I changed the image of a dashboard card to a custom image. It always had a color overlay, so I tried to fix it.

ksucpea commented 1 year ago

First of all, I'd just like to say it's pretty cool that you got everything correct when adding the new feature. I've been working on a new update that would change your code slightly, however. Also, I think I know a more efficient way to remove the overlay. I can update the repo with the new update and you can adjust it if you'd like, so that you are listed as a contributor? I could also add your edits to my version and push the update later. Just let me know what you'd like to do. Thanks

tibogeeraerts commented 1 year ago

Thanks for the feedback. I would really appreciate it if I could join the list of contributors. You can choose when to update, to me it can be in the next update when you are done with everything.

ksucpea commented 1 year ago

I just updated the repo but it doesn't have any of your changes except you'll see the part where I tested your toggle with my version. Feel free to open another merge or edit this one. I think all you really have to do is change the local storage to sync storage.

tibogeeraerts commented 1 year ago

This is my first commit from my repo to another local so I don't really understand it. I hope this solved the issue?

ksucpea commented 1 year ago

I'm not really too sure how this works either, but when I click view changes, all of the new update is removed and it seems like if I merged it, it would delete the new update from the repo. Can you try adding your code to the most recent version of the repo instead? Might need to close this merge and open a new one.