search

kubernetes-sigs / usage-metrics-collector

High fidelity and scalable capacity and usage metrics for Kubernetes clusters
Apache License 2.0
118 stars 20 forks source link

CAdvisor Network Metrics Update #121

Closed ichekrygin closed 9 months ago

ichekrygin commented 9 months ago

Replace the CAdvisor client with the HttpClient analog.

Kubernetes kubelet does not expose the CAdvsor RESTFull API endpoints (as of 1.16 or so). Thus, we cannot use the cadvisor's "native" client to export metrics 😔. Instead, Kubelet exposes cadvisor metrics via the "/metrics/cadvisor" endpoint, which could be "scraped" to collect metrics in the prometheus format.

This PR replaces cadvisor client with http.client alternative to collect cadvisor metrics via scraping kubelet's "/metrics/cadvisor".

linux-foundation-easycla[bot] commented 9 months ago

CLA Signed

The committers listed above are authorized under a signed CLA.

k8s-ci-robot commented 9 months ago

This issue is currently awaiting triage.

If usage-metrics-collector contributors determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
k8s-ci-robot commented 9 months ago

Hi @ichekrygin. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
ndipebot commented 9 months ago

/ok-to-test

ndipebot commented 9 months ago

/approve /lgtm

k8s-ci-robot commented 9 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: campoy, ichekrygin, ndipebot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/usage-metrics-collector/blob/main/OWNERS)~~ [campoy,ndipebot] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
ichekrygin commented 9 months ago

/retest

ndipebot commented 9 months ago

/lgtm