search

kubernetes-sigs / usage-metrics-collector

High fidelity and scalable capacity and usage metrics for Kubernetes clusters
Apache License 2.0
118 stars 20 forks source link

non-leader metrics-prometheus-collector eagerly computes metrics #42

Closed pwittrock closed 1 year ago

pwittrock commented 1 year ago
logicalhan commented 1 year ago

/triage accepted

pwittrock commented 1 year ago

Had to significantly re-work this after thoroughly testing it in a cluster. We should follow up with some e2e tests that run for ~hours and do things like rolling updates to ensure a proper handoff. That is a non-trivial task though, and shouldn't block fixing the issue.

ndipebot commented 1 year ago

/approve /lgtm

k8s-ci-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ndipebot, pwittrock

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/usage-metrics-collector/blob/main/OWNERS)~~ [pwittrock] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment