search

kubernetes-sigs / usage-metrics-collector

High fidelity and scalable capacity and usage metrics for Kubernetes clusters
Apache License 2.0
123 stars 21 forks source link

Refactor constants into types for clarity's sake #48

Closed campoy closed 1 year ago

campoy commented 1 year ago

This PR creates types for the constants in the project in uses them to ensure the right values are being used in the right context.

This includes the types:

All of these types are of string kind and the constants are declared in groups with the intention of helping readers understand their structure.

k8s-ci-robot commented 1 year ago

Hi @campoy. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
campoy commented 1 year ago

Working on the rebase.

pwittrock commented 1 year ago

/lgtm /approve

campoy commented 1 year ago

/retest

k8s-ci-robot commented 1 year ago

@campoy: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to [this](https://github.com/kubernetes-sigs/usage-metrics-collector/pull/48#issuecomment-1499456391): >/retest Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
pwittrock commented 1 year ago

/ok-to-test

pwittrock commented 1 year ago

/retest

pwittrock commented 1 year ago

/lgtm /approve

pwittrock commented 1 year ago

/ok-to-test /lgtm /approve

k8s-ci-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: campoy, pwittrock

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/usage-metrics-collector/blob/main/OWNERS)~~ [pwittrock] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment