search

kubernetes-sigs / usage-metrics-collector

High fidelity and scalable capacity and usage metrics for Kubernetes clusters
Apache License 2.0
123 stars 21 forks source link

Expose pprof endpoints on metrics-node-sampler #68

Closed campoy closed 1 year ago

campoy commented 1 year ago

This exposes /debug/pprof/$PROFILE endpoints for each pprof profile.

Exposing these endpoints does not have any effect on the performance of the node sampler, so there's no need for flags to switch this behavior on/off.

k8s-ci-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: campoy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/usage-metrics-collector/blob/main/OWNERS)~~ [campoy] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
k8s-ci-robot commented 1 year ago

This issue is currently awaiting triage.

If usage-metrics-collector contributors determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
pmorie commented 1 year ago

/lgtm