search

kubernetes-sigs / usage-metrics-collector

High fidelity and scalable capacity and usage metrics for Kubernetes clusters
Apache License 2.0
118 stars 20 forks source link

Add a "verify" target to makefile, including license header verification #7

Closed ehashman closed 1 year ago

ehashman commented 1 year ago

Closes #4.

/kind cleanup

Hopefully the new presubmits should pop up in response to this PR...

k8s-ci-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ehashman, pwittrock

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/usage-metrics-collector/blob/main/OWNERS)~~ [ehashman,pwittrock] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
pwittrock commented 1 year ago

/lgtm

k8s-ci-robot commented 1 year ago

New changes are detected. LGTM label has been removed.

ehashman commented 1 year ago

/triage accepted

ehashman commented 1 year ago

/retest-required

ehashman commented 1 year ago

/skip

k8s-ci-robot commented 1 year ago

@ehashman: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-usage-metrics-collector-build 0752e5fc64e3e4a1a6f5da3005b06689c2648398 link true /test pull-usage-metrics-collector-build
pull-usage-metrics-collector-test 0752e5fc64e3e4a1a6f5da3005b06689c2648398 link true /test pull-usage-metrics-collector-test

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).