search

kubernetes-sigs / usage-metrics-collector

High fidelity and scalable capacity and usage metrics for Kubernetes clusters
Apache License 2.0
118 stars 20 forks source link

Add separate generate targets to Makefile for protoc #9

Closed ehashman closed 1 year ago

ehashman commented 1 year ago

The build currently won't work because we need to install the tool for generation into the test environment: https://grpc.io/docs/protoc-installation/

Let's add verify/update targets for the generated code, and improve the Makefile so it can install what it needs for that.

(See also https://github.com/kubernetes/test-infra/pull/28422)

/kind cleanup /assign

k8s-ci-robot commented 1 year ago

@ehashman: This issue is currently awaiting triage.

If usage-metrics-collector contributors determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.