search

kubernetes-sigs / usage-metrics-collector

High fidelity and scalable capacity and usage metrics for Kubernetes clusters
Apache License 2.0
118 stars 20 forks source link

Use floor to determine exponential histogram bucket lowwer bound #94

Closed ndipebot closed 1 year ago

ndipebot commented 1 year ago

Rounding causes histogram lower bound to higher than true max sample value. Use floor to ensure than computed bucket lower bound is always smaller than max value.

k8s-ci-robot commented 1 year ago

This issue is currently awaiting triage.

If usage-metrics-collector contributors determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
k8s-ci-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ndipebot, pwittrock

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/usage-metrics-collector/blob/main/OWNERS)~~ [ndipebot,pwittrock] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment