search

kubernetes / enhancements

Enhancements tracking repo for Kubernetes
Apache License 2.0
3.33k stars 1.44k forks source link

Priority and Fairness for API Server Requests #1040

Closed yue9944882 closed 5 months ago

yue9944882 commented 5 years ago

Enhancement Description

Please to keep this description up to date. This will help the Enhancement Team track efficiently the evolution of the enhancement

kacole2 commented 5 years ago

@yue9944882 the 1.15 enhancement freeze was on 4/30. The KEP is still in a provisional state and still requires graduation criteria. This will not make it in 1.15 without filing an exception and fixing what I had just mentioned.

kacole2 commented 5 years ago

/milestone v1.15 /sig api-machinery /stage alpha

makoscafee commented 5 years ago

Hey, @yue9944882 👋 I'm the v1.15 docs Lead. Does this enhancement require any new docs (or modifications)?

Just a friendly reminder we're looking for a PR against k/website (branch dev-1.15) due by Thursday, May 30th. It would be great if it's the start of the full documentation, but even a placeholder PR is acceptable. Let me know if you have any questions!

kacole2 commented 5 years ago

Hi @yue9944882 @MikeSpreitzer . Code Freeze is Thursday, May 30th 2019 @ EOD PST. All enhancements going into the release must be code-complete, including tests, and have docs PRs open.

Please list all current k/k PRs so they can be tracked going into freeze. If the PRs aren't merged by freeze, this feature will slip for the 1.15 release cycle. Only release-blocking issues and PRs will be allowed in the milestone.

If you know this will slip, please reply back and let us know. Thanks!

kacole2 commented 5 years ago

Hi @yue9944882 @MikeSpreitzer , today is code freeze for the 1.15 release cycle. I do not see a reply for any k/k PRs to track for this merge. It's now being marked as At Risk in the 1.15 Enhancement Tracking Sheet. If there is no response, or you respond with PRs to track and they are not merged by EOD PST, this will be dropped from the 1.15 Milestone. After this point, only release-blocking issues and PRs will be allowed in the milestone with an exception.

kacole2 commented 5 years ago

/milestone clear

evillgenius75 commented 5 years ago

Hi @MikeSpreitzer and @yue9944882 , I'm a 1.16 Enhancement Shadow. Is this feature going to be graduating to alpha stage in 1.16? Please let me know so it can be added to the 1.16 Tracking Spreadsheet. If not's graduating, I will remove it from the milestone and change the tracked label.

I see you have PR kubernetes/kubernetes#78966 referenced above, please include any other relevant k/k PRs in this issue so they can be tracked properly.

Milestone dates are Enhancement Freeze 7/30 and Code Freeze 8/29.

Thank you.

yue9944882 commented 5 years ago

hey, yes please track the feature in the 1.16 milestone. matter of fact this feature is literally active from 1.15 on, as you see in the pull above there's ~300 discussions over the api model since april this year. there're also other poc repos under development:

we will get into 1.16 this time 👏🏻

kacole2 commented 5 years ago

/milestone v1.16

sethmccombs commented 4 years ago

Hey @yue9944882 @MikeSpreitzer,

I'm one of the v1.16 docs shadows. Does this enhancement (or the work planned for v1.16) require any new docs (or modifications to existing docs)? If not, can you please update the 1.16 Enhancement Tracker Sheet (or let me know and I’ll do so)

If so, just a friendly reminder we're looking for a PR against k/website (branch dev-1.16) due by Friday, August 23rd, it can just be a placeholder PR at this time. Let me know if you have any questions!

MikeSpreitzer commented 4 years ago

@evillgenius75 : Yes, this feature needs docs. I do not see how to update the tracking spreadsheet myself; is that something I leave to you?

@sethmccombs : please see my plea for help on the sig-docs Slack channel of the Kubernetes workspace

kacole2 commented 4 years ago

@MikeSpreitzer @yue9944882 code freeze for 1.16 is on Thursday 8/29. Are there any outstanding k/k PRs that still need to be merged for this to go Alpha?

MikeSpreitzer commented 4 years ago

Yes. At least #81834. I think @yue9944882 is planning a revision to that PR. I think there may be a little more want to do after that.

kacole2 commented 4 years ago

Hi @MikeSpreitzer @yue9944882 it looks as though https://github.com/kubernetes/kubernetes/pull/81834 didn't merge before code freeze and it's not in the Tide Merge Pool. This feature is going to be bumped from v1.16. If you would still like to have this be a part of the 1.16 release, please file an exception

MikeSpreitzer commented 4 years ago

What about the doc side of things? Isn't there some undoing needed there too?

kacole2 commented 4 years ago

@simplytunde can you comment WRT to docs?

simplytunde commented 4 years ago

@kacole2 @MikeSpreitzer The docs PR needs to be closed.

jeremyrickard commented 4 years ago

Hey there @MikeSpreitzer -- 1.17 Enhancements shadow here 👋 . I wanted to check in and see if you think this Enhancement will be graduating to alpha in 1.17?

The current release schedule is:

If you do, I'll add it to the 1.17 tracking sheet (https://bit.ly/k8s117-enhancements). Once coding begins please list all relevant k/k PRs in this issue so they can be tracked properly. 👍

yue9944882 commented 4 years ago

@jeremyrickard thanks, we are targeting 1.17 this time, the implementations are almost finished in 1.16 but we missed it out of some reason

jeremyrickard commented 4 years ago

Thanks @yue9944882. I'll flip the status in our tracking spreadsheet and add it to the milestone.

jeremyrickard commented 4 years ago

/milestone v1.17

daminisatya commented 4 years ago

Hello, @yue9944882 @MikeSpreitzer I'm 1.17 docs lead.

Does this enhancement (or the work planned for v1.17) require any new docs (or modifications to existing docs)? If not, can you please update the 1.17 Enhancement Tracker Sheet (or let me know and I'll do so)

If so, just a friendly reminder we're looking for a PR against k/website (branch dev-1.17) due by Friday, November 8th, it can just be a placeholder PR at this time. Let me know if you have any questions!

yue9944882 commented 4 years ago

@daminisatya we have got a doc PR opened from the last milestone https://github.com/kubernetes/website/pull/15899, we will revive this one to file user-facing documentation to the kubernetes site.

jeremyrickard commented 4 years ago

Hey, @yue9944882 @MikeSpreitzer

Jeremy from the 1.17 enhancements team here 👋

We're closing in on the 1.17 code freeze pretty soon (Nov 14th) so I wanted to check in and see how this was going? You mentioned before that it was mostly implemented for 1.16, could you please let us know if you'll be finishing for 1.17? It looks like there are a few incomplete items in your umbrella tracking issue: https://github.com/kubernetes/kubernetes/issues/76846

Thanks in advance!

daminisatya commented 4 years ago

Hey @yue9944882 @MikeSpreitzer

Just a friendly reminder, we're hoping to have a placeholder Docs PR against k/website (branch dev-1.17) by Friday, Nov 8th. (4 more days left)

daminisatya commented 4 years ago

Hello @yue9944882 @MikeSpreitzer

Just a friendly reminder, We're hoping to have a placeholder Docs PR against k/website (branch dev-1.17) by Friday, Nov 8th. (2 more days left)

jeremyrickard commented 4 years ago

Hi @yue9944882 @MikeSpreitzer, today is code freeze for the 1.17 release cycle. It looks like the k/k PRs have not yet been merged. We're flagging as At Risk in the 1.17 Enhancement Tracking Sheet. Do you think they will be merged by the EoD of the today? After that point, only release-blocking issues and PRs will be allowed in the milestone with an exception.

jeremyrickard commented 4 years ago

Hey @yue9944882 @MikeSpreitzer Code freeze is now in effect for the 1.17 release. It doesn't look like the some of the PRs in your umbrella issue were added to a merge pool in time. I'm going to go ahead and remove this from the milestone, if you feel it is release blocking or urgent that it gets merged, please file an exception request with @guineveresaenger. Thanks!

jeremyrickard commented 4 years ago

/milestone clear

jeremyrickard commented 4 years ago

If you'd like to file an exception, please see here

jeremyrickard commented 4 years ago

Hi @yue9944882 @MikeSpreitzer,

1.18 enhancements team reaching out 👋 It looks like this just missed the code freeze last time, so I wanted to check and see if you're planning on introducing this in 1.18?

Thanks in advance!

yue9944882 commented 4 years ago

@jeremyrickard the feature has been partially merged into master branch and we're moving on to 1.18. plz mark us as tracked, thanks

jeremyrickard commented 4 years ago

/milestone v1.18

iheanyi1 commented 4 years ago

Hello @yue9944882 ,

I'm 1.18 docs shadow.

Just want to know if this enhancement work planned for 1.18 require any new docs (or modifications to existing docs)? If not, can you please update the 1.18 Enhancement Tracker Sheet (or let me know and I'll do so)

If so, just a friendly reminder we're looking for a PR against k/website (branch dev-1.18) due by Friday, Feb 28th, it can just be a placeholder PR at this time. Let me know if you have any questions!

Warm regards,

chima

MikeSpreitzer commented 4 years ago

Yes, we plan to add doc. This is a new feature and definitely requires doc.

johnbelamaric commented 4 years ago

Hi @MikeSpreitzer I am an enhancements shadow for 1.18. Are there open PRs that are needed to complete the 1.18 work for this? If so, please list them here so we can track them in the release team. Thanks.

MikeSpreitzer commented 4 years ago

We have one open PR, https://github.com/kubernetes/kubernetes/pull/87754 . That will be the first time that the plumbing for this feature is complete. We expect to do further polishing before the release, as time allows.

johnbelamaric commented 4 years ago

Thanks Mike, we'll track that one. If others come up, please link them here.

iheanyi1 commented 4 years ago

Yes, we plan to add doc. This is a new feature and definitely requires doc. Hi @MikeSpreitzer , Remember your update quoted above, just a friendly reminder we're looking for a PR against k/website (branch dev-1.18) due by Friday, Feb 28th, it can just be a placeholder PR at this time. Keep the good work, we hope you will meet deadline we are working with. Thank you.

VineethReddy02 commented 4 years ago

Hi @MikeSpreitzer My name is Vineeth, 1.18 Docs release lead. This message is in regard to docs placeholder PR for this enhancement. As we are left with 2 more days for the deadline. It would be great to have placeholder PR in place asap. Thanks!

MikeSpreitzer commented 4 years ago

We had a doc PR: https://github.com/kubernetes/website/pull/17463 , but it got closed because it wasn't ready in time for 1.17. We have a new independent doc PR: https://github.com/kubernetes/website/pull/19319

palnabarun commented 4 years ago

/milestone clear

(removing this enhancement issue from the v1.18 milestone as the milestone is complete)

msedzins commented 4 years ago

Hey there @yue9944882 , @MikeSpreitzer -- 1.19 Enhancements shadow here. I wanted to check in and see if you think this Enhancement will be graduating in 1.19?

In order to have this part of the release:

  1. The KEP PR must be merged in an implementable state
  2. The KEP must have test plans
  3. The KEP must have graduation criteria.

The current release schedule is:

If you do, I'll add it to the 1.19 tracking sheet (http://bit.ly/k8s-1-19-enhancements). Once coding begins please list all relevant k/k PRs in this issue so they can be tracked properly. 👍

Thanks!

yue9944882 commented 4 years ago

@msedzins thanks, the alpha version is already merged/announced and we're working on moving the feature to beta stage in 1.19. plz add us to the tracking list.

msedzins commented 4 years ago

Awesome, thank you! I'll go ahead and add it to the tracking sheet :)

msedzins commented 4 years ago

One more thing:

please remember about requirement list, specifically point 2: "The KEP must have graduation criteria." Should cover beta stage.

palnabarun commented 4 years ago

/stage beta /milestone v1.19

msedzins commented 4 years ago

Hi @yue9944882 , @MikeSpreitzer ,

Note that recently the KEP format has changed.

1620 merged recently, adding production readiness review questions to the KEP template. Please take this opportunity to reformat your KEP and also answer the questions add to the template in that PR.

Also please remember about graduation criteria.

Thanks!

msedzins commented 4 years ago

Hi @yue9944882 , @MikeSpreitzer ,

Please not that enhancement freeze is on Tuesday, May 19. There are still not graduation criteria in KEP.

Regards, Mirek

yue9944882 commented 4 years ago

hi @msedzins, there's an opening pull adding beta critiria to the KEP https://github.com/kubernetes/enhancements/pull/1632. do we need to merge it before the freeze?