search

kubernetes / enhancements

Enhancements tracking repo for Kubernetes
Apache License 2.0
3.41k stars 1.47k forks source link

Priority and Fairness for API Server Requests #1040

Closed yue9944882 closed 8 months ago

yue9944882 commented 5 years ago

Enhancement Description

Please to keep this description up to date. This will help the Enhancement Team track efficiently the evolution of the enhancement

kikisdeliveryservice commented 4 years ago

@yue9944882 yes graduation criteria is required in the merged KEP.

kikisdeliveryservice commented 4 years ago

Unfortunately the deadline for the 1.19 Enhancement freeze has passed. The existing KEP is missing graduation criteria for beta which is what was being targeted for 1.19. It looks like the open PR #1632 has some unaddressed comments and is not approved/has not merged.

For now this is being removed from the milestone and 1.19 tracking sheet. If there is a need to get this in, please file an enhancement exception.

fejta-bot commented 4 years ago

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /lifecycle stale

yue9944882 commented 4 years ago

/remove-lifecycle stale

kikisdeliveryservice commented 4 years ago

Hi @yue9944882 !

Enhancements Lead here, do you still intend to go beta in 1.20?

Thanks! Kirsten

yue9944882 commented 4 years ago

@kikisdeliveryservice thanks for reminding, and we're moving toward 1.20 as discussed in last week's sync'up.

kikisdeliveryservice commented 4 years ago

Thanks for the update @yue9944882

If you could please update the description of this issue to reflect this and also ensure that your kep is in the proper format as per :https://github.com/kubernetes/enhancements/tree/master/keps/NNNN-kep-template (it seems to be missing a kep.yaml) that would be great.

Best, Kirsten

kikisdeliveryservice commented 4 years ago

/milestone v1.20

MorrisLaw commented 4 years ago

Hi @yue9944882 -- 1.20 Enhancements Shadow here 👋

Friendly ping to remind you that the Enhancements Freeze deadline is October 6th.

Please update the KEP to match the new format detailed in https://github.com/kubernetes/enhancements/tree/master/keps/NNNN-kep-template.

Appreciate your work on this!

Regards, Jeremy

MorrisLaw commented 3 years ago

Hi @yue9944882 ,

Since your Enhancement is scheduled to be in 1.20, please keep in mind the important upcoming dates: Friday, Nov 6th: Week 8 - Docs Placeholder PR deadline Thursday, Nov 12th: Week 9 - Code Freeze

As a reminder, please link all of your k/k PR as well as docs PR to this issue so we can track them.

Best, Jeremy

reylejano commented 3 years ago

Hello @MikeSpreitzer @yue9944882 , 1.20 Docs shadow here.

Does this enhancement work planned for 1.20 require any new docs or modification to existing docs?

If so, please follows the steps here to open a PR against the dev-1.20 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Nov 6th.

Also take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.

Thank you!

reylejano commented 3 years ago

Hi @MikeSpreitzer @yue9944882

The docs placeholder deadline is almost here. Please make sure to create a placeholder PR against the dev-1.20 branch in the k/website before the deadline

Also, please keep in mind the important upcoming dates:

As a reminder, please link all of your k/k PR as well as docs PR to this issue for the release team to track.

yue9944882 commented 3 years ago

@reylejano-rxm i created a placeholder PR here: https://github.com/kubernetes/website/pull/24877

MorrisLaw commented 3 years ago

Hi @MikeSpreitzer @yue9944882

The code freeze deadline is almost here. Please make sure to link k/k PRs here so that we can track them and make sure to have them merged by the code freeze deadline or an exception will need to be made to keep this in the 1.20 milestone.

Also, please keep in mind the important upcoming dates:

MikeSpreitzer commented 3 years ago

We want to get this feature to beta in 1.20. That means we need

The following PRs would be nice to have but are not considered blockers:

MikeSpreitzer commented 3 years ago

There is one doc PR:

kikisdeliveryservice commented 3 years ago

@lavalamp @adtac @MikeSpreitzer @yue9944882 (not sure who to ping here)

https://github.com/kubernetes/kubernetes/pull/96527 is replacing https://github.com/kubernetes/kubernetes/pull/96213 entirely due to test issues correct? And is the only required PR for this to move to beta?

adtac commented 3 years ago

https://github.com/kubernetes/kubernetes/pull/96527 is the last code change PR to graduate this to beta. There is still https://github.com/kubernetes/website/pull/24975 which is open that is pending approval -- that updates the website and docs.

kikisdeliveryservice commented 3 years ago

Hi @adtac

Code Freeze is now in effect. Your PR is still unmerged, and is missing a LGTM. If you believe this should be in the 1.20 Release, please file an Exception.

Best, Kirsten

lavalamp commented 3 years ago

/milestone 1.20

this had an lgtm earlier and will have one shortly

k8s-ci-robot commented 3 years ago

@lavalamp: The provided milestone is not valid for this repository. Milestones in this repository: [keps-beta, keps-ga, v1.17, v1.18, v1.19, v1.20, v1.21, v1.22, v1.23]

Use /milestone clear to clear the milestone.

In response to [this](https://github.com/kubernetes/enhancements/issues/1040#issuecomment-726541780): >/milestone 1.20 > >this had an lgtm earlier and will have one shortly Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
lavalamp commented 3 years ago

Looks like we might need another day after all. We'll file an exception request.

kikisdeliveryservice commented 3 years ago

Looks like we might need another day after all. We'll file an exception request.

I spoke with @adtac earlier tonight and they are planning on filing an exception to have enough time to complete. :smile:

adtac commented 3 years ago

exception request: https://groups.google.com/g/kubernetes-sig-api-machinery/c/o--_PcGMxik

kikisdeliveryservice commented 3 years ago

To circle back around on this: @lavalamp @hasheddan @jeremyrickard @dims

Can I get a signoff that this is now Done? (we were waiting for the outcomes of some tests but I didnt hear an official word)

jeremyrickard commented 3 years ago

I think it's safe to go, we haven't seen any negative impact on the testing AFAICT.

adtac commented 3 years ago

Can I get a signoff that this is now Done?

perhaps I misunderstood, but are you asking if we can close this issue? I'd like to keep this open till the feature becomes GA if that's alright (which won't be for many more months)

jeremyrickard commented 3 years ago

@adtac no more around if we can consider this done for 1.20. Since we had the contigency PR ready to go, we still had this marked as "At Risk" in case we needed to back it out.

kikisdeliveryservice commented 3 years ago

@adtac what Jeremy said above :smile:

Also we keep these issues open until you update the KEP and mark its status as implemented. So you'll need to go GA and then after that is done-done you'll pr the KEP, marking as implemented and then at the end of that release, we go thru and close this issue.

Until then, keep linking all PRs to this.

HTH!

fejta-bot commented 3 years ago

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale

wojtek-t commented 3 years ago

/remove-lifecycle stale

supriya-premkumar commented 3 years ago

👋🏼 Hi @yue9944882,

This is Supriya, v1.22 enhancement shadow here. For the enhancement to be included in the 1.22 milestone, it must meet the following criteria:

The KEP must be updated with the current beta version

Please make sure to follow all the instructions and update the KEP to include this.

Thank you!

wojtek-t commented 3 years ago

@supriya-premkumar - once https://github.com/kubernetes/enhancements/pull/2700 merges, the "latest milestone" will be updated. I'm reluctant to changing the "beta" milestone to 1.22, because the feature actually went beta in 1.20. We're just evolving it now by adding improving some functionalities.

supriya-premkumar commented 3 years ago

Thank you @wojtek-t, that makes sense.

PI-Victor commented 3 years ago

Heya @wojtek-t, Docs release lead for 1.22 here, this KEP did not opt-in for any docs changes for the upcoming 1.22 release, could you please confirm that this is true and there are no docs updates required?

thank you

wojtek-t commented 3 years ago

@PI-Victor - no new docs required

supriya-premkumar commented 3 years ago

Hi @wojtek-t, Just a reminder that we are one week away from the code freeze(July 8th, 2021) and now that the PRs (#102171 and #102185) are merged, this issue is on track for the 1.22 release 🎉

Also, please let us know if there are any pending PRs that need to be tracked as well. Thank you!

wojtek-t commented 3 years ago

There are still a couple PRs that we need here - we're working on them.

supriya-premkumar commented 3 years ago

Thank you @wojtek-t for the update, marking this issue as atRisk until the remaining PRs are merged.

supriya-premkumar commented 3 years ago

Hi @wojtek-t, I just wanted to send a reminder that we have just 1 more day to get all the remaining PRs merged before the code freeze deadline tomorrow on Thursday, July 8th at 18:00 Pacific Time.

wojtek-t commented 3 years ago

Due to the need to revert one of the PRs, the subsequent ones won't merge. Given the potential risk, I think we won't be asking for exception at this point and postpone further changes to 1.23.

That said - I think it shouldn't remove the PR from being tracked. In this cycle it was effectively extending the existing logic (while still leaving in beta) in couple different dimensions and multiple of them were successfully extended. It's just we didn't do all the enhancements we wanted.

supriya-premkumar commented 3 years ago

Hi @wojtek-t, Just confirming that this issue needs to be tracked for the 1.22 release and the PR is not merged will roll into the 1.23 release?

wojtek-t commented 3 years ago

Just confirming that this issue needs to be tracked for the 1.22 release

I think we should track it.

the PR is not merged will roll into the 1.23 release?

correct

salaxander commented 3 years ago

/milestone v1.23

salaxander commented 3 years ago

Hi @wojtek-t! 1.23 Enhancements team here. Just checking in as we approach enhancements freeze 11:59pm PST pm Thursday 09/09. Here's where this enhancement currently stands:

Looks like we'll still need a PRR for the stable graduation.

Thanks!

wojtek-t commented 3 years ago

@salaxander - we're not graduating to GA - it's just another Beta. The PRR is ready for that.

salaxander commented 3 years ago

Ah thanks @wojtek-t! I'll update our tracking

mehabhalodiya commented 3 years ago

Hi @yue9944882 1.23 Docs Shadow here :wave:

This enhancement issue is listed as 'None required' for docs in the tracking sheet. Though docs are complete, I believe we need a small PR to update the feature gate. If I'm mistaken, let me know!

Otherwise, please follow the steps detailed in the documentation to open a PR against the dev-1.23 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thu November 18, 11:59 PM PDT.

Thanks!

wojtek-t commented 3 years ago

This enhancement issue is listed as 'None required' for docs in the tracking sheet. Though docs are complete, I believe we need a small PR to update the feature gate. If I'm mistaken, let me know!

We don't - we don't graduate and we don't add any feature gate.

salaxander commented 2 years ago

Hi @wojtek-t 👋. Checking in once more as we approach 1.23 code freeze at 6:00 pm PST on Tuesday, November 16.

Please ensure the following items are completed:

As always, we are here to help should questions come up.

Thanks!!