search

kubernetes / enhancements

Enhancements tracking repo for Kubernetes
Apache License 2.0
3.41k stars 1.47k forks source link

Priority and Fairness for API Server Requests #1040

Closed yue9944882 closed 8 months ago

yue9944882 commented 5 years ago

Enhancement Description

Please to keep this description up to date. This will help the Enhancement Team track efficiently the evolution of the enhancement

salaxander commented 2 years ago

Hey @wojtek-t - If my understanding of this is correct it looks like all PRs for code freeze have merged?

wojtek-t commented 2 years ago

@salaxander - technically, we didn't do everything we wanted, but also - it's "the next beta" and all the critical things happened.

k8s-triage-robot commented 2 years ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

wojtek-t commented 2 years ago

/remove-lifecycle stale

k8s-triage-robot commented 2 years ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

wojtek-t commented 2 years ago

/remove-lifecycle stale

k8s-triage-robot commented 1 year ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot commented 1 year ago

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

wojtek-t commented 1 year ago

/remove-lifecycle rotten

deads2k commented 1 year ago

/milestone v1.27 /label lead-opted-in

Atharva-Shinde commented 1 year ago

Hello @yue9944882 @MikeSpreitzer 👋, Enhancements team here.

Just checking in as we approach Enhancements freeze on 18:00 PDT Thursday 9th February 2023.

This enhancement is targeting for stage stable for 1.27 (correct me, if otherwise)

Here's where this enhancement currently stands:

For this KEP, we would need to update the following:

The status of this enhancement is marked as at risk. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

MikeSpreitzer commented 1 year ago

@Atharva-Shinde : we have been aiming to take this GA in 1.27. We will work on the needed updates.

MikeSpreitzer commented 1 year ago

Feature tracking: https://github.com/orgs/kubernetes/projects/117/views/1

MikeSpreitzer commented 1 year ago

On second thought, we decided that we should hold GA until 1.28, since a major improvement (concurrency borrowing between priority levels) just appeared in 1.26.

MikeSpreitzer commented 1 year ago

@Atharva-Shinde

Atharva-Shinde commented 1 year ago

On second thought, we decided that we should hold GA until 1.28, since a major improvement (concurrency borrowing between priority levels) just appeared in 1.26.

ack. I'll remove this KEP from the current 1.27 milestone.

Atharva-Shinde commented 1 year ago

/milestone clear

k8s-triage-robot commented 1 year ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

wojtek-t commented 1 year ago

/remove-lifecycle stale

deads2k commented 1 year ago

/milestone v1.28 /label lead-opted-in

Atharva-Shinde commented 1 year ago

Hello @yue9944882 @MikeSpreitzer 👋, Enhancements team here.

Just checking in as we approach Enhancements freeze on Thursday, 16th June 2023.

This enhancement is targeting for stage stable for 1.28 (correct me, if otherwise)

Here's where this enhancement currently stands:

For this KEP, we would need to update the following:

The status of this enhancement is marked as at risk. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

Atharva-Shinde commented 1 year ago

Hey @yue9944882 @MikeSpreitzer, We would just need to update the latest-milestone field under kep.yaml to 1.28, apart from that everything else seems to be addressed. Please make the change within 24 hours else you would have to file an exception request. Thanks :)

Atharva-Shinde commented 1 year ago

Hello @MikeSpreitzer @yue9944882, 1.28 Enhancements Lead here. This enhancement unfortunately do not satisfy the requirements for v1.28 enhancements freeze. Feel free to file an exception request to add this back to the release tracking process. Thanks!

Atharva-Shinde commented 1 year ago

/milestone clear

taniaduggal commented 1 year ago

Hello @yue9944882 1.28 Docs Shadow here.

Does this enhancement work planned for 1.28 require any new docs or modification to existing docs?

If so, please follows the steps here to open a PR against dev-1.28 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday 20th July 2023.

Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.

Thank you!

Rishit-dagli commented 1 year ago

@taniaduggal This is removed from 1.28 release so I have marked this as "removed form release" and there is no need for 1.28 docs PR

MikeSpreitzer commented 1 year ago

@Rishit-dagli and others. Eek. I got overwhelmed with other stuff 2 weeks ago. Not sure I understand the current status. Earlier we were thinking of going to stable in 1.28 but have since realized this feature will not be ready. We are still doing work on it. I see that the KEP needs to be updated to the latest template. We can work on that. Are you saying that this feature will be removed in 1.28 or stay in its current beta status?

wojtek-t commented 1 year ago

/milestone v1.29

rayandas commented 1 year ago

Hello @yue9944882 @MikeSpreitzer 👋, v1.29 Enhancements team here.

Just checking in as we approach enhancements freeze on 01:00 UTC, Friday, 6th October, 2023.

This enhancement is targeting for stage stable for v1.29 (correct me, if otherwise)

Here's where this enhancement currently stands:

With all the KEP requirements in place and merged into k/enhancements, this enhancement is all good for the upcoming enhancements freeze. 🚀

The status of this enhancement is marked as tracked for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

katcosgrove commented 12 months ago

Hey there @yue9944882 👋, v1.29 Docs Lead here. Does this enhancement work planned for v1.29 require any new docs or modification to existing docs? If so, please follows the steps here to open a PR against dev-1.29 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday, 19 October 2023. Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release. Thank you!

katcosgrove commented 11 months ago

Hi @yue9944882 and @MikeSpreitzer! The deadline to open a placeholder PR against k/website for required documentation is Thursday, 19 October. Could you please update me on the status of docs for this enhancement? Thank you!

MikeSpreitzer commented 11 months ago

Metrics missing from doc:

The debug endpoint doc looks current.

Will open a PR.

MikeSpreitzer commented 11 months ago

See https://github.com/kubernetes/website/pull/43549

tengqm commented 11 months ago

Metrics missing from doc:

* current_inqueue_seats

* current_executing_seats

* epoch_advance_total

The debug endpoint doc looks current.

Will open a PR.

When working on an observability tool, I found that the APF is exposing a lot of metrics, most of which are more like developer oriented ones. The number of metrics almost amounts to that for the API server itself. From a user's perspective, I don't want to be bothered by the epoch_advance_toal or *_r_* or *_s_* metrics. I don't even know how to interpret them even after spending time reading the documents. I only care whether APF is working properly. There are my gut feeling when checking these metrics. Sorry for being a little skeptic on the metrics design.

MikeSpreitzer commented 11 months ago

@tengqm: I agree with your observation. We can certainly consider changes to the design.

One concern that I bring is that some of these metrics are like logs in this sense: while users would not normally look at them and interpret them, having them available to someone trying to debug something that happened in the past is valuable.

logicalhan commented 11 months ago

@tengqm: I agree with your observation. We can certainly consider changes to the design.

One concern that I bring is that some of these metrics are like logs in this sense: while users would not normally look at them and interpret them, having them available to someone trying to debug something that happened in the past is valuable.

Do we need all the P&F metrics or can we truncate some of them? Alternatively, we can gate P&F metrics behind a flag, or maybe even a dedicated endpoint.

MikeSpreitzer commented 11 months ago

A special endpoint is likely to not be scraped in many environments. I wonder about control through -v. This is not strictly "logging", but it is serving the same underlying concerns and would be a knob that users generally want to turn in tandem.

rayandas commented 11 months ago

Hey again @yue9944882 @MikeSpreitzer 👋, 1.29 Enhancements team here,

Just checking in as we approach code freeze at 01:00 UTC Wednesday 1st November 2023: .

Here's where this enhancement currently stands:

Please update the Issue description to include all the related PRs of this KEP under the stable section in the Github Issue description. The status for this KEP is currently at risk for code freeze.

Also, please let me know if there are other PRs in k/k we should be tracking for this KEP. As always, we are here to help if any questions come up. Thanks!

a-mccarthy commented 11 months ago

Hi @yue9944882 @MikeSpreitzer, 👋 from the v1.29 Release Team-Communications! We would like to check if you have any plans to publish a blog for this KEP regarding new features, removals, and deprecations for this release.

If so, you need to open a PR placeholder in the website repository. The deadline will be on Tuesday 14th November 2023 (after the Docs deadline PR ready for review)

Here is the 1.29 calendar

npolshakova commented 11 months ago

Hey @yue9944882 @MikeSpreitzer, Enhancements lead here. Are both of these PRs tracking the code changes for this KEP?

tkashem commented 11 months ago

@npolshakova yes, all the code PRs have merged, thanks!

and the conformance test pr is being tracked here: https://github.com/kubernetes/kubernetes/pull/121718

tkashem commented 10 months ago

draft PR for doc update: https://github.com/kubernetes/website/pull/43946

salehsedghpour commented 9 months ago

Hi @yue9944882 @MikeSpreitzer , 👋 1.30 Enhancements lead here As it has graduated to Stable and the KEP status is still implementable, may you please update the status to implemented and close this issue once the update PR has merged?

salehsedghpour commented 9 months ago

/remove-label lead-opted-in

salehsedghpour commented 8 months ago

Hello 👋 1.30 Enhancements Lead here,

I'm closing milestone 1.29 now, If you wish to progress this enhancement in v1.30, please follow the instructions here to opt in the enhancement and make sure the lead-opted-in label is set so it can get added to the tracking board and finally add /milestone v1.30. Thanks!

/milestone clear

MikeSpreitzer commented 8 months ago

/label lead-opted-in

MikeSpreitzer commented 8 months ago

@salehsedghpour : I created #4429 to update the kep.yaml. I am not entirely clear on where to put the lead-opted-in label, you see I just tried and nothing happened.

k8s-ci-robot commented 8 months ago

@MikeSpreitzer: Can not set label lead-opted-in: Must be member in one of these teams: [release-team-enhancements release-team-leads sig-api-machinery-leads sig-apps-leads sig-architecture-leads sig-auth-leads sig-autoscaling-leads sig-cli-leads sig-cloud-provider-leads sig-cluster-lifecycle-leads sig-contributor-experience-leads sig-docs-leads sig-instrumentation-leads sig-k8s-infra-leads sig-multicluster-leads sig-network-leads sig-node-leads sig-release-leads sig-scalability-leads sig-scheduling-leads sig-security-leads sig-storage-leads sig-testing-leads sig-windows-leads]

In response to [this](https://github.com/kubernetes/enhancements/issues/1040#issuecomment-1904704722): >/label lead-opted-in > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
deads2k commented 8 months ago

/milestone v1.30 /label lead-opted-in

salehsedghpour commented 8 months ago

@MikeSpreitzer, Thanks for the update. I guess I made a mistake here, to clarify things, is there going to be any changes on this KEP (except the implemented status)? If not, this issue can be closed as it is completed (stable), right?