search

kubernetes / enhancements

Enhancements tracking repo for Kubernetes
Apache License 2.0
3.43k stars 1.48k forks source link

Add a configurable default constraint to PodTopologySpread #1258

Closed alculquicondor closed 2 years ago

alculquicondor commented 5 years ago

Enhancement Description

alculquicondor commented 5 years ago

/sig scheduling

mrbobbytables commented 5 years ago

Hey there @alculquicondor -- 1.17 Enhancements lead here. I wanted to check in and see if you think this Enhancement will be graduating to alpha in 1.17?

Just a reminder that for it to be accepted -- the KEP must be merged, in an implementable state and have both a test plan and graduation criteria defined before the Enhancement Freeze.

The current release schedule is:

If you do think it'll make it, please let me know.

Thanks!

alculquicondor commented 5 years ago

Hi Bob. I believe I'll have it ready before the Enhancements Freeze.

/assign

mrbobbytables commented 5 years ago

great, thanks @alculquicondor I'll add it to the tracking sheet :) /stage alpha /milestone v1.17

jeremyrickard commented 5 years ago

Hey @alculquicondor, friendly reminder that enhancement freeze is quickly approaching (EOD PT, October 15th). Your KEP will need to be updated to the implementable state in order for us to include it in the release. It looks like it was merged, but is still listed as provisional.

alculquicondor commented 5 years ago

Thanks @jeremyrickard. We already have a PR to set that flag.

jeremyrickard commented 5 years ago

👍 great @alculquicondor.

alculquicondor commented 5 years ago

It's now marked as implementable.

daminisatya commented 4 years ago

Hello, @alculquicondor I'm 1.17 docs lead.

Does this enhancement (or the work planned for v1.17) require any new docs (or modifications to existing docs)? If not, can you please update the 1.17 Enhancement Tracker Sheet (or let me know and I'll do so)

If so, just a friendly reminder we're looking for a PR against k/website (branch dev-1.17) due by Friday, November 8th, it can just be a placeholder PR at this time. Let me know if you have any questions!

alculquicondor commented 4 years ago

Hello @daminisatya, these are the docs that need a few updates https://kubernetes.io/docs/concepts/workloads/pods/pod-topology-spread-constraints/ https://kubernetes.io/docs/concepts/scheduling/kube-scheduler/

daminisatya commented 4 years ago

Thank you @alculquicondor Make sure you open a Docs PR against k/website (branch dev-1.17) due by Friday, November 8th.

daminisatya commented 4 years ago

Hello @alculquicondor

Just a friendly reminder, We're hoping to have a placeholder Docs PR against k/website (branch dev-1.17) by Friday, Nov 8th. (4 more days left)

alculquicondor commented 4 years ago

Done kubernetes/website#17409

palnabarun commented 4 years ago

Hi @alculquicondor

I am one of the Enhancements Shadow for the 1.17 Release Team. We are very near to the Code Freeze (Nov 14th) for this release cycle. Just checking in about the progress of this enhancement. I see that https://github.com/kubernetes/kubernetes/pull/84606 was filed in relation to this. Is there any other PR related to this enhancement? If yes, can you please link them here?

Thank you in advance :smile:

alculquicondor commented 4 years ago

1/2: kubernetes/kubernetes#84874

palnabarun commented 4 years ago

@alculquicondor Awesome! Thank you for the updates. :) Please let us know if and when 2/2 is filed.

palnabarun commented 4 years ago

Hi @alculquicondor , tomorrow is code freeze for the 1.17 release cycle. It looks like the k/k PR has not yet been merged. We're flagging as the enhancement as At Risk in the 1.17 Enhancement Tracking Sheet.

Do you think they will be merged by the EoD of the 14th (Thursday)? After that point, only release-blocking issues and PRs will be allowed in the milestone with an exception.

alculquicondor commented 4 years ago

Hello @palnabarun even though the API changes got approved, we hit several blockers in the implementation. I don't think we can make it before the freeze. Could you please take it out of the release?

palnabarun commented 4 years ago

Ah! Okay. Thank you for the updates. I am going ahead and removing the enhancement from this cycle.

We will look forward to having it in the next cycle.

palnabarun commented 4 years ago

/milestone clear

jeremyrickard commented 4 years ago

Hey there @alculquicondor,

1.18 Enhancements team here 👋

1.18 has kicked off this week, so I'm reaching out to see if you think this will make it into 1.18? Looks like you didn't make it to code freeze in the last cycle, any thoughts on that happening this time around? Looks like kubernetes/kubernetes#84874 is still open.

Let us know if you plan on introducing this as alpha in 1.18!

alculquicondor commented 4 years ago

Hello @jeremyrickard. We will indeed be working on this. The PR will need rework in the light of kubernetes/kubernetes#85737. Do you know when the release calendar will be posted?

jeremyrickard commented 4 years ago

@alculquicondor there is a PR with the calendar that hasn't quite merged yet, but the dates are:

v1.18 Start: January 6 Enhance Freeze: January 28 Code Freeze: March 5 Docs Ready: March 16 v1.18 Release: March 24

jeremyrickard commented 4 years ago

/milestone v1.18

iheanyi1 commented 4 years ago

Hello @alculquicondor ,

I'm 1.18 docs shadow.

Just want to know if this enhancement work planned for 1.18 require any new docs (or modifications to existing docs)? If not, can you please update the 1.18 Enhancement Tracker Sheet (or let me know and I'll do so)

If so, just a friendly reminder we're looking for a PR against k/website (branch dev-1.18) due by Friday, Feb 28th, it can just be a placeholder PR at this time. Warm regards,

chima

kikisdeliveryservice commented 4 years ago

Hi @alculquicondor !

As a reminder that the Code Freeze is Thursday 5th March. Can you please link all the k/k PRs or any other PRs that should be tracked for this enhancement? So far I have https://github.com/kubernetes/kubernetes/pull/84874 for this Enhancement.

Thanks! The 1.18 Enhancements Team

iheanyi1 commented 4 years ago

Hello @alculquicondor ,

I'm 1.18 docs shadow.

Just want to know if this enhancement work planned for 1.18 require any new docs (or modifications to existing docs)? If not, can you please update the 1.18 Enhancement Tracker Sheet (or let me know and I'll do so)

If so, just a friendly reminder we're looking for a PR against k/website (branch dev-1.18) due by Friday, Feb 28th, it can just be a placeholder PR at this time.

alculquicondor commented 4 years ago

Hello @kikisdeliveryservice, all my efforts are now directed towards #1451. I'll let you know when I have PRs for this.

@iheanyi1, here is the PR for docs kubernetes/website#19170

sftim commented 4 years ago

Following https://github.com/kubernetes/enhancements/issues/1258#issuecomment-587086972 it does look to me as if a few docs changes are needed, and there is indeed a placeholder PR open already.

kikisdeliveryservice commented 4 years ago

@alculquicondor Is this still targeted for 1.18? Code freeze is March 5th and PRs should be merged by then.

alculquicondor commented 4 years ago

kubernetes/kubernetes#88671 has the implementation of the feature and it's on review.

alculquicondor commented 4 years ago

kubernetes/kubernetes#88671 was merged.

In light of the performance results that we have today, in 1.18 we are not moving forward with replacing DefaultPodTopologySpread with PodTopologySpread+defaults, as described here https://github.com/kubernetes/enhancements/blob/master/keps/sig-scheduling/20190926-default-even-pod-spreading.md#relationship-with-defaultpodtopologyspread-plugin

Other than documentation (kubernetes/website#19170) the work for this release should be considered done.

harshanarayana commented 4 years ago

Hey there @alculquicondor, 1.19 Enhancements shadow here. I wanted to check in and see if you think this Enhancement will be graduating in 1.19?

In order to have this part of the release:

  1. The KEP PR must be merged in an implementable state
  2. The KEP must have test plans
  3. The KEP must have graduation criteria.

The current release schedule is:

If you do, I'll add it to the 1.19 tracking sheet (http://bit.ly/k8s-1-19-enhancements). Once coding begins please list all relevant k/k PRs in this issue so they can be tracked properly. 👍

Thanks!

alculquicondor commented 4 years ago

The KEP is already in place. I have to update the target to this release https://github.com/kubernetes/enhancements/blob/master/keps/sig-scheduling/20190926-default-even-pod-spreading.md

palnabarun commented 4 years ago

/milestone clear

(removing this from the v1.18 milestone as that is complete)

harshanarayana commented 4 years ago

@alculquicondor Thank you for getting back to me with an update. I just went through the KEP and noticed that it is missing Graduation Criteria with regards to v1.19. Can you please update the same?

I will update the tracking sheet accordingly to consider this a valid entry into v1.19 👍

alculquicondor commented 4 years ago

We are going to alpha this release. We didn't make it in 1.18 https://github.com/kubernetes/enhancements/issues/1258#issuecomment-594026704

harshanarayana commented 4 years ago

@alculquicondor Thanks. I have updated the tracking sheet to reflect the same. Can you please ensure that the KEP also indicates that v1.19 is going to be alpha stage ? The KEP still shows Alpha (v1.18):. Thanks again. 👍

palnabarun commented 4 years ago

/stage alpha /milestone v1.19

harshanarayana commented 4 years ago

Hey @alculquicondor, thank you for update the KEP Documentation for Graduation Criteria. Tracking sheet has been updated with the details.

Thanks again for your time and contributions. 🖖

harshanarayana commented 4 years ago

Hi @alculquicondor, member of Enhancements team for the v1.19 here with a quick update.

PR #1620 was merged recently, adding production readiness review questions to the KEP template. We are not making it mandatory for the 1.19 release cycle, but it would be great if the PRR questionnaire is filled in the KEP.

divya-mohan0209 commented 4 years ago

Hello @alculquicondor , I'm one of the v1.19 docs shadows.

Could you please let me know if this piece of enhancement work planned for 1.19 release requires any new docs (or modifications to existing docs)?

If not, can you please update the 1.19 Enhancement Tracker Sheet (or let me know and I'll do so)

If yes, just a friendly reminder we're looking for a PR against k/website (branch dev-1.19) due by Friday, June 12, it can just be a placeholder PR at this time.

Please do let me know if you have any questions!

Regards, Divya

alculquicondor commented 4 years ago

I will raise a PR to update https://kubernetes.io/docs/concepts/workloads/pods/pod-topology-spread-constraints/

harshanarayana commented 4 years ago

Hey @alculquicondor, I am with the enhancements team for the v1.19 release cycle as a shadow.

The code freeze deadline for the Enhancement is Thursday, June 25. I am checking in to see if there is any other k/k PR that you have outside of https://github.com/kubernetes/kubernetes/issues/80639 with regards to this enhancement and if so, would you be able to point me in the direction of the PR so that the same can be updated in the tracking sheet

Have a wonderful day. 🖖

divya-mohan0209 commented 4 years ago

Hello @alculquicondor . Gentle reminder to update the Docs placeholder PR on this issue so that we can ensure it's tracked appropriately.

Thanks!

harshanarayana commented 4 years ago

Hi @alculquicondor, I am with the enhancements teams for the v1.19 cycle as the shadow.

I noticed that the PR kubernetes/kubernetes#91793 has been merged against the k/k. Is there any other PR you are anticipating for this enhancement in the v1.19 cycle that needs to be tracked?

Have a wonderful day. 🖖

alculquicondor commented 4 years ago

That's it for 1.19, other than docs.

alculquicondor commented 4 years ago

kubernetes/website#21689

harshanarayana commented 4 years ago

Hi, @alculquicondor

This probably not applicable to this enhancement as all the things for this are already in place. However, this is a follow-up to the communication that went out to k-dev today. There has been a revision to the release schedule of v1.19 as follows.

Thursday, July 9th: Week 13 - Code Freeze
Thursday, July 16th: Week 14 - Docs must be completed and reviewed
Tuesday, August 25th: Week 20 - Kubernetes v1.19.0 released
Thursday, August 27th: Week 20 - Release Retrospective

You can find the revised Schedule in the sig-release Repo

Please let me know if you have any questions. 🖖

kikisdeliveryservice commented 4 years ago

This graduated to alpha in 1.19. If you'd like to work towards beta in 1.20 please let us know.

/milestone clear

(removing this enhancement issue from the v1.19 milestone as the milestone is complete)