search

kubernetes / enhancements

Enhancements tracking repo for Kubernetes
Apache License 2.0
3.38k stars 1.45k forks source link

cAdvisor-less, CRI-full Container and Pod Stats #2371

Open haircommander opened 3 years ago

haircommander commented 3 years ago

Enhancement Description

haircommander commented 3 years ago

/sig node

ehashman commented 3 years ago

/milestone v1.21

JamesLaverack commented 3 years ago

Hey @haircommander and @bobbypage, enhancements 1.21 shadow here,

Enhancements Freeze is 2 days away, Feb 9th EOD PST

The enhancements team is aware that KEP update is currently in progress (PR #2364). Please make sure to work on PRR questionnaires and requirements and get it merged before the freeze. For PRR related questions or to boost the PR for PRR review, please reach out in Slack on the #prod-readiness channel.

Any enhancements that do not complete the following requirements by the freeze will require an exception.

annajung commented 3 years ago

Hi @haircommander and @bobbypage, 1.21 Enhancements Lead here.

Enhancements Freeze is now in effect.

Unfortunately, your KEP needed to be updated and the PR has not yet merged. If you wish to be included in the 1.21 Release, please submit an Exception Request as soon as possible.

/milestone clear

ehashman commented 3 years ago

/milestone v1.22

salaxander commented 3 years ago

Hey @haircommander and @bobbypage - 1.22 enhancements team here! Just a reminder that enhancements freeze is coming up on 5/13. We'll need the KEP merged before then to get this included in the 1.22 release.

Let us know if there's anything we can do to help before then!

salaxander commented 3 years ago

@haircommander @bobbypage #2364 merged so we've got you tracked for 1.22 :)

PI-Victor commented 3 years ago

Hello @haircommander @bobbypage 👋, 1.22 Docs release lead here. This enhancement is marked as ‘Needs Docs’ for 1.22 release.

Please follow the steps detailed in the documentation to open a PR against dev-1.22 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Fri July 9, 11:59 PM PDT.
 Also, take a look at Documenting for a release to familiarize yourself with the docs requirement for the release. 
Thank you!

haircommander commented 3 years ago

thanks for the heads up @PI-Victor !

ehashman commented 3 years ago

xref https://github.com/kubernetes/kubernetes/pull/102789

haircommander commented 3 years ago

xref initial kubelet implementation kubernetes/kubernetes#103095

salaxander commented 3 years ago

Hey @bobbypage and @haircommander - Just checking in as we're about 2 weeks away from 1.22 code freeze. I've got https://github.com/kubernetes/kubernetes/pull/103095 and https://github.com/kubernetes/kubernetes/pull/103095 tracked as the open k/k PRs. Are there any other open or merged PRs we should be tracking? Thanks!

haircommander commented 3 years ago

none opened yet! I will post them here if we do. Thanks for your work @salaxander

salaxander commented 3 years ago

Hey @haircommander - One more check-in as we're a week out from 1.22 code freeze. Any updates on if you expect https://github.com/kubernetes/kubernetes/pull/103095 and https://github.com/kubernetes/kubernetes/pull/103095 to merge before the deadline?

Thanks!

haircommander commented 3 years ago

Thanks for checking! I do expect them to merge. We're waiting on a e2e POC which I'm working on :)

salaxander commented 3 years ago

Hi @haircommander - One last ping (sorry!). Code freeze is tomorrow evening (PST), so those two open PRs will need to merge before then for this to be included in 1.22. Let me know if there's anything we can do to help :)

haircommander commented 3 years ago

thanks for the reminder @salaxander ! I can imagine I'll be requesting an extension, but there's a day to figure that out :)

Priyankasaggu11929 commented 2 years ago

/milestone v1.23

k8s-ci-robot commented 2 years ago

@Priyankasaggu11929: You must be a member of the kubernetes/milestone-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your and have them propose you as an additional delegate for this responsibility.

In response to [this](https://github.com/kubernetes/enhancements/issues/2371#issuecomment-910229733): >/milestone v1.23 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
salaxander commented 2 years ago

/milestone v1.23

ehashman commented 2 years ago

/remove-stage beta /stage alpha

this slipped in 1.22 and is not yet alpha

ehashman commented 2 years ago

@Priyankasaggu11929 please update the corresponding spreadsheet phase

Priyankasaggu11929 commented 2 years ago

Updated the enhancements sheet to change the KEP's stage to alpha. Thanks for pointing, @ehashman.

Priyankasaggu11929 commented 2 years ago

Hi @haircommander ! 1.23 Enhancements team here. Just checking in as we approach enhancements freeze on Thursday 09/09. Here's where this enhancement currently stands:

Looks like for this one, we would just need to update the following:

Thanks!

haircommander commented 2 years ago

Looks like for this one, we would just need to update the following:

* update issue description with the latest `Enhancements target`

done!

updated the PR in https://github.com/kubernetes/enhancements/pull/2812 Thanks!

thank you for the reminder and for your work :)

Priyankasaggu11929 commented 2 years ago

Thanks for the changes @haircommander. Once the PR is merged, we're all good for the enhancements freeze. :)

jlbutler commented 2 years ago

Hi @haircommander :wave: 1.23 Docs lead here.

This enhancement is marked as 'Needs Docs' for the 1.23 release.

Please follow the steps detailed in the documentation to open a PR against the dev-1.23 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thu November 18, 11:59 PM PDT.

Also, if needed take a look at Documenting for a release to familiarize yourself with the docs requirement for the release.

Thanks!

Priyankasaggu11929 commented 2 years ago

Hello @haircommander 👋

Checking in once more as we approach 1.23 code freeze at 6:00 pm PST on Tuesday, November 16.

Please ensure the following items are completed:

As always, we are here to help should questions come up.

Thanks you so much! 🙂

haircommander commented 2 years ago

Thank you @Priyankasaggu11929 ! I have tagged the one kubernetes PR in the description, it has merged, and I have https://github.com/kubernetes/website/pull/28044 opened and ready to be populated. Please let me know if I'm missing anything, but I believe we are all set here

Priyankasaggu11929 commented 2 years ago

Thank you, @haircommander. I wanted to be sure in case if I'm missing any PRs (other than the one already listed above). With the above comment, all looks fine to me.

Thanks so much once again! 🙂

hosseinsalahi commented 2 years ago

Hello @haircommander

v1.24 Enhancements team here.

Just checking in as we approach enhancements freeze on 18:00pm PT on Thursday Feb 3rd, 2022. This enhancement is targeting beta for v1.24, is this correct?

Here’s where this enhancement currently stands:

In the key.yaml latest-milestone should point to the correct release.

The status of this enhancement is marked as tracked. Please update the merged KEP's kep.yaml to reflect the stage as current release cycle 1.24. Thanks!

ehashman commented 2 years ago

@encodeflush this is going to beta, I don't think this is ready: https://github.com/kubernetes/enhancements/blob/35c768227c6d6dde20c6ca7084abb8d00b9e4d82/keps/sig-node/2371-cri-pod-container-stats/kep.yaml#L21-L22

/stage beta

haircommander commented 2 years ago

https://github.com/kubernetes/enhancements/pull/3003 updates to beta for 1.24, along with some other pieces

nate-double-u commented 2 years ago

Hi @haircommander :wave: 1.24 Docs lead here.

This enhancement is marked as Needs Docs for the 1.24 release.

Please follow the steps detailed in the documentation to open a PR against the dev-1.24 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday, March 31st, 2022 @ 18:00 PDT.

Also, if needed take a look at Documenting for a release to familiarize yourself with the docs requirement for the release.

Thanks!

ehashman commented 2 years ago

/milestone clear per https://docs.google.com/document/d/1Ne57gvidMEWXR70OxxnRkYquAoMpt56o75oZtg-OeBg/edit#bookmark=id.w24ewvhebv4u

gracenng commented 2 years ago

Removing this from 1.24 release

sftim commented 2 years ago

This enhancement will need docs, even if it doesn't reach beta for a while.

Priyankasaggu11929 commented 2 years ago

/milestone v1.25

rhockenbury commented 2 years ago

👋 Hello @haircommander and @bobbypage,

1.25 Enhancements team here. Just checking in as we approach enhancements freeze on 18:00 PST on Thursday June 23, 2022.

This enhancement is targeting for stage beta for 1.25, correct?

Here's where this enhancement currently stands:

Looks like for this one, we would just need to update the following:

The status of this enhancement is marked as at risk. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

haircommander commented 2 years ago

hello! this enhancement has an update to the alpha criteria, but is not moving to beta. What is the way I can best reflect that here and on the tracking sheet?

haircommander commented 2 years ago

I have added the test plan update to https://github.com/kubernetes/enhancements/pull/3353

Priyankasaggu11929 commented 2 years ago

Hello @haircommander 👋, 1.25 Enhancements Lead this side.

this enhancement has an update to the alpha criteria, but is not moving to beta. What is the way I can best reflect that here and on the tracking sheet?

The best way would be to track the enhancement as alpha & update the Implementation history section in the KEP README.md with appropriate information.

Another bit, could you please update the kep.yaml file in the open PR https://github.com/kubernetes/enhancements/pull/3353 to add latest-milestone: "v1.25". Thank you so much!

rhockenbury commented 2 years ago

Please try to merge #3403 before enhancements freeze today at 18:00 PST.

haircommander commented 2 years ago

3403 has merged!

sethmccombs commented 2 years ago

Hello @haircommander, @bobbypage! :wave:,

1.25 Release Docs Shadow here.

Does this enhancement work planned for 1.25 require any new docs or modification to existing docs?

If so, please make sure to open a PR against the dev-1.25 branch in the k/website repo (follow the steps here)

This PR can be just a placeholder at this time and must be created before August 4.

Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release. Thank you!

cici37 commented 2 years ago

Hello 👋, 1.25 Release Lead here.

Unfortunately, this enhancement did not meet the code freeze criteria because there are still unmerged k/k code PRs.

If you still wish to progress this enhancement in v1.25, please file an exception request. Thank you so much!

/milestone clear

ruiwen-zhao commented 1 year ago

/milestone v1.26

k8s-ci-robot commented 1 year ago

@ruiwen-zhao: You must be a member of the kubernetes/milestone-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your Milestone Maintainers Team and have them propose you as an additional delegate for this responsibility.

In response to [this](https://github.com/kubernetes/enhancements/issues/2371#issuecomment-1263823856): >/milestone v1.26 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
marosset commented 1 year ago

/milestone v1.26 /label lead-opted-in (I'm doing this on behalf of @ruiwen-zhao / SIG-node)

rhockenbury commented 1 year ago

Is this graduating to beta or should we track it as a major change to alpha?

/label tracked/yes /remove-label tracked/no