Remove transient node predicates from KCCM's service controller

[alexanderConstantinescu]

Enhancement Description

• One-line enhancement description (can be used as a release note): Remove transient node predicates from KCCM's service controller
• Kubernetes Enhancement Proposal: https://github.com/kubernetes/enhancements/blob/master/keps/sig-network/3458-remove-transient-node-predicates-from-service-controller/README.md
• Discussion Link: https://github.com/kubernetes/kubernetes/pull/109706#issuecomment-1112737473 / https://github.com/kubernetes/kubernetes/pull/109706#issuecomment-1179336082
• Primary contact (assignee): @alexanderConstantinescu
• Responsible SIGs: sig-network / sig-cloud-provider
• Enhancement target (which target equals to which milestone):
  • Alpha release target (x.y): 1.26
  • Beta release target (x.y): 1.27
  • Stable release target (x.y): 1.30
• [x] Alpha
  • [x] KEP (k/enhancements) update PR(s):
  • https://github.com/kubernetes/enhancements/pull/3460
  • [x] Code (k/k) update PR(s):
  • https://github.com/kubernetes/kubernetes/pull/115204
  • [ ] Docs (k/website) update PR(s):
• [x] Beta
  • [x] KEP (k/enhancements) update PR(s):
  • https://github.com/kubernetes/enhancements/pull/4088
  • [ ] Code (k/k) update PR(s):
  • [ ] Docs (k/website) update(s):
• [x] Stable
  • [x] KEP (k/enhancements) update PR(s):
  • https://github.com/kubernetes/enhancements/pull/4257
  • [x] Code (k/k) update PR(s):
  • https://github.com/kubernetes/kubernetes/pull/122961
  • [ ] Docs (k/website) update(s):

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

[alexanderConstantinescu]

/sig network /sig cloud-provider

[thockin]

Punting to 1.27

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue or PR as fresh with /remove-lifecycle stale
• Mark this issue or PR as rotten with /lifecycle rotten
• Close this issue or PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[thockin]

/label lead-opted-in

[alexanderConstantinescu]

/retitle Remove transient node predicates from KCCM's service controller

[marosset]

@thockin @alexanderConstantinescu can one of you confirm that this targeting beta for v1.27. Thanks!

[alexanderConstantinescu]

Yes, that is correct and what we've discussed / agreed on the KEP. Maybe @thockin wants to give the final confirmation?

[thockin]

yes please - this one doesn't have APi so doesn't need an alpha

[marosset]

Thanks @thockin @alexanderConstantinescu

[marosset]

Once https://github.com/kubernetes/enhancements/pull/3835 merges this enhancement will be ready for inclusion in v1.27

[shatoboar]

With https://github.com/kubernetes/enhancements/pull/3835 merged this enhancement is ready to be tracked for 1.27. Thanks!

[shatoboar]

Hi @thockin 👋, Checking in as we approach 1.27 code freeze at 17:00 PDT on Tuesday 14th March 2023. Please ensure the following items are completed:

• [ ] All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
• [ ] All PRs are fully merged by the code freeze deadline.

Please let me know what PRs in k/k I should be tracking for this KEP. As always, we are here to help should questions come up. Thanks!

[mickeyboxell]

@alexanderConstantinescu was there a Docs PR opened against dev-1.27 branch in the k/website repo?

If not, please take a look at Documenting for a release - PR Ready for Review to get your PR ready for review as soon as possible. 01:00 UTC Wednesday 22nd March 2023 / 17:00 PDT Tuesday 21st March 2023 is the official deadline.

This PR will need a doc review by Tuesday 4th April 2023 to get this into the release. Please reach out to required SIGs to get their review. Thank you!

[alexanderConstantinescu]

Hi @mickeyboxell!

I am not sure what features qualify for a doc PR. My PR introduces no user-facing changes, would that still require a doc PR? I am asking because the link provided states:

Do your best to describe your feature and how to use it.

But there is no "explicit way to use", I guess one can see it as a "performance improvement" of sorts.

[thockin]

I think a release note is all that should be needed here.

On Tue, Mar 21, 2023 at 3:48 AM Alexander Constantinescu < @.***> wrote:

Hi @mickeyboxell https://github.com/mickeyboxell!

I am not sure what features qualify for a doc PR. My PR introduces no user-facing changes, would that still require a doc PR? I am asking because the link provided states:

Do your best to describe your feature and how to use it.

But there is no "explicit way to use", I guess one can see it as a "performance improvement" of sorts.

— Reply to this email directly, view it on GitHub https://github.com/kubernetes/enhancements/issues/3458#issuecomment-1477620297, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABKWAVEZZ2EJCH65G3XXFBTW5GBPHANCNFSM552KGYSQ . You are receiving this because you were mentioned.Message ID: @.***>

[thockin]

NEXT: Aiming for GA in 1.28

[thockin]

Are we on-target for GA iin 1.28?

[salehsedghpour]

Hello @alexanderConstantinescu 👋, Enhancements team here.

Just checking in as we approach enhancements freeze on 01:00 UTC Friday, 16th June 2023.

This enhancement is targeting for stage stable for 1.28 (correct me, if otherwise)

Here's where this enhancement currently stands:

• [X] KEP readme using the latest template has been merged into the k/enhancements repo.
• [ ] KEP status is marked as implementable for latest-milestone: 1.28
• [X] KEP readme has a updated detailed test plan section filled out
• [X] KEP readme has up to date graduation criteria
• [ ] KEP has a production readiness review that has been completed and merged into k/enhancements.

For this KEP, we would just need to update the following:

• The kep.yaml file is a bit confusing for me, is this enhancement targeting1.28 for the stage stable or beta?

The status of this enhancement is marked as at risk. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

[thockin]

@alexanderConstantinescu https://github.com/kubernetes/enhancements/blob/master/keps/sig-network/3458-remove-transient-node-predicates-from-service-controller/kep.yaml still says "beta" and needs final PRR signoff (thanks, @wojtek-t for the poke)

[alexanderConstantinescu]

Are we on-target for GA iin 1.28?

Sorry for the late reply to this: the KEP says GA in 1.29 that isn't advanced to 1.28 just because the release went well, right?

[alexanderConstantinescu]

@alexanderConstantinescu https://github.com/kubernetes/enhancements/blob/master/keps/sig-network/3458-remove-transient-node-predicates-from-service-controller/kep.yaml still says "beta" and needs final PRR signoff (thanks, @wojtek-t for the poke)

Thanks for the reminder! Here's the PR: https://github.com/kubernetes/enhancements/pull/4088

I didn't update the stable milestone because of I mentioned above

[thockin]

Sorry, somehow I thought it was GA this release. Milestone bumped

[Rishit-dagli]

Hello @thockin @alexanderConstantinescu :wave:, 1.28 Docs Lead here.

Does this enhancement work planned for 1.28 require any new docs or modification to existing docs?

If so, please follows the steps here to open a PR against dev-1.28 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday 20th July 2023.

Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.

Thank you!

[alexanderConstantinescu]

@Rishit-dagli : sorry for the late reply

Does this enhancement work planned for 1.28 require any new docs or modification to existing docs?

No, it does not.

[salehsedghpour]

Hey again @alexanderConstantinescu :wave: Just checking in as we approach Code freeze at 01:00 UTC Friday, 19th July 2023 . Here’s the enhancement’s state for the upcoming code freeze:

• [ ] All the PRs that are related to your enhancement are linked in the above issue description (for tracking purposes). This includes code, tests, and documentation related PR/s.
• [x] All code related PR/s are merged or are in merge-ready state ( i.e they have approved and lgtm labels applied) by the code freeze deadline. This includes any tests related PR/s too. For this enhancement, it looks like the following code related PR/s are open and they need to be merged or should be in merge-ready state before the code freeze commences :
  • https://github.com/kubernetes/kubernetes/pull/115204

Please keep the issue description up-to-date with all the PR/s that are associated with this KEP and let me know if there are other PR/s in k/k we should be tracking for this KEP. As always, we are here to help if any questions come up. Thanks!

[Atharva-Shinde]

Hey @alexanderConstantinescu 👋 Enhancements Lead here, With https://github.com/kubernetes/kubernetes/pull/115204 merged as per the issue description, this enhancement is now tracked for v1.28 Code Freeze. Thanks!

[thockin]

I am tracking this for GA in 1.29 - is that correct?

[alexanderConstantinescu]

I am tracking this for GA in 1.29 - is that correct?

Yes, that is correct.

[salehsedghpour]

Hello @alexanderConstantinescu 👋, Enhancements team here.

Just checking in as we approach enhancements freeze on Friday, 6th October 2023.

This enhancement is targeting for stage stable for 1.29 (correct me, if otherwise)

Here's where this enhancement currently stands:

• [ ] KEP readme using the latest template has been merged into the k/enhancements repo.
• [ ] KEP status is marked as implemented for latest-milestone: 1.29.
• [ ] KEP readme has up-to-date graduation criteria
• [ ] KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here).

For this KEP, we would just need to add/update the following:

• KEP readme using the latest template has been merged into the k/enhancements repo
• The kep.yaml file based on the recent changes
• Update the issue description.

The status of this enhancement is marked as at risk for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

[BenTheElder]

I think this PR needs a metadata bump like https://github.com/kubernetes/enhancements/pull/4088/files

[salehsedghpour]

Hello @alexanderConstantinescu 👋,

checking in once more as we approach the 1.29 enhancement freeze deadline on 01:00 UTC, Friday, 6th October, 2023. The status of this enhancement is marked as at risk. But It looks like https://github.com/kubernetes/enhancements/pull/4257 addresses most of the requirements. With this the status will be updated to tracked for the enhancement freeze.

Please let me know if I missed anything.

I would like to also ask to keep the issue description up-to-date with proper information such as the link to the merged PR.

[alexanderConstantinescu]

But It looks like #4257 addresses most of the requirements. With this the status will be updated to tracked for the enhancement freeze.

Hi @salehsedghpour ! That PR has merged and should fulfill all necessary requirements for progressing this KEP to the next phase. Let me know if anything is missing, but this KEP should be ready now for the next Kube release.

[salehsedghpour]

Hi @alexanderConstantinescu, thanks for the update. the status is now tracked for the enhancement freeze.

[harshitasao]

Hi @alexanderConstantinescu 👋, v1.29 Docs Shadow here Does this enhancement work planned for v1.29 require any new docs or modification to existing docs? If so, please follows the steps here to open a PR against dev-1.29 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday, 19 October 2023. Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release. Thank you!

[salehsedghpour]

Hey again @alexanderConstantinescu 👋 Enhancements team here,

Just checking in as we approach code freeze at 01:00 UTC Wednesday 1st November.

Here's where this enhancement currently stands:

• [ ] All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
• [ ] All PR/s are ready to be merged (they have approved and lgtm labels applied) by the code freeze deadline. This includes tests.

Please update the Issue description to include all the related PRs (including https://github.com/kubernetes/kubernetes/pull/121091, I guess) of this KEP under a new stable section in the Github Issue description. The status for this KEP is currently at risk for code freeze.

Also, please let me know if there are any other PRs in k/k we should be tracking for this KEP. As always, we are here to help if any questions come up. Thanks!

[kcmartin]

Hi @alexanderConstantinescu ! 👋 from the v1.29 Release Team-Communications! We would like to check if you have any plans to publish a blog for this KEP regarding new features, removals, and deprecations for this release.

If so, you need to open a PR placeholder in the website repository. The deadline will be on Tuesday 14th November 2023 (after the Docs deadline PR ready for review)

Here's the 1.29 Calendar

[npolshakova]

Hello @alexanderConstantinescu 👋, 1.29 Enhancements team here.

With all the implementation(code related) PRs merged as per the issue description, this enhancement is now marked as tracked for code freeze for the 1.29 Code Freeze! 🚀

The test freeze is 01:00 UTC Wednesday 15th November 2023 / 18:00 PDT Tuesday 14th November 2023. Please make sure all test PRs are merged in by then. The tracked test PRs for this KEP are:

• https://github.com/kubernetes/kubernetes/pull/121091

Please let me know if there are additional test PRs we should track. Thanks!

[salehsedghpour]

/remove-label lead-opted-in

[salehsedghpour]

Hello 👋 1.30 Enhancements Lead here,

I'm closing milestone 1.29 now, If you wish to progress this enhancement in v1.30, please follow the instructions here to opt in the enhancement and make sure the lead-opted-in label is set so it can get added to the tracking board and finally add /milestone v1.30. Thanks!

/milestone clear

[thockin]

Pinging this after sig-net - let's decide if this moves to GA in 1.30

[aojea]

I'll let it soak at least one release more https://github.com/kubernetes/kubernetes/pull/121116, WDYT @alexanderConstantinescu , just to get signal, these things take some time to detect

[alexanderConstantinescu]

I'll let it soak at least one release more https://github.com/kubernetes/kubernetes/pull/121116, WDYT @alexanderConstantinescu , just to get signal, these things take some time to detect

I am fine with this. I'm filing a PR updating the enhancement with a stable milestone set for 1.30

[thockin]

1.30 is next - did you mean 31?

[alexanderConstantinescu]

1.30 is next - did you mean 31?

I meant 1.30. My understanding is: if we want to "soak for one more release" then we extend the current milestone by one release. This feature was marked stable: 1.29, but I forgot to update the feature gate in Kube for this feature in 1.29, so it's still in beta. Extending beta by one release therefore means we go to stable in 1.30...does this makes sense?

@aojea : did you mean that we should go to stable in 1.31?

[thockin]

For context: It's been beta for 1.27, 1.28, 1.29 - majhor providers are all using those versions now.

I'm OK if we want to let it ride one more, but I am not sure it's buying us anything

[alexanderConstantinescu]

I'm OK if we want to let it ride one more, but I am not sure it's buying us anything

+1

I'll let Antonio decide, following how strongly he feels about it

[aojea]

For context: It's been beta for 1.27, 1.28, 1.29 - majhor providers are all using those versions now.

I'm OK if we want to let it ride one more, but I am not sure it's buying us anything

not really, major providers have to revendor and use to take some time to pick up these changes, all cloud provider code moved to external cloud providers, and it was beta but we had a fix in 1.29 with backports https://github.com/kubernetes/kubernetes/pull/121116/commits/2032b742546bd78ea6ac257c6e61fa9a31f67cfe

[aojea]

although, we are going to remove the cloud providers tests this release (most probably), so it will be useless to get it another release more, @alexanderConstantinescu go ahead and GA this then

[thockin]

Also, from the original bug:

""" This PR should have no effect on >= 1.27 since the predicates are already aligned under the feature gate StableLoadBalancerNodeSet, but this should get in so that we guard against the broken behaviour should someone turn that feature gate off. """

It was about a regression on 1.26 or when the gate was disabled.

[aojea]

It was about a regression on 1.26 or when the gate was disabled.

oh, my fault, sorry, I skipped that super important detail 😓