Open kannon92 opened 1 year ago
/sig node
/stage alpha /milestone v1.29 /label lead-opted-in
/assign
Hello @kannon92 π, Enhancements team here.
Just checking in as we approach enhancements freeze on 01:00 UTC, Friday, 6th October, 2023.
This enhancement is targeting for stage alpha
for v1.29 (correct me, if otherwise)
Here's where this enhancement currently stands:
implementable
for latest-milestone: 1.29
. KEPs targeting stable
will need to be marked as implemented
after code PRs are merged and the feature gates are removed.For this KEP https://github.com/kubernetes/enhancements/pull/4198 seems to take care of everything. Please make sure that the PR is merged in time. Will move the KEP to tracked for enhancement freeze
once everything is merged into k/enhancements.
The status of this enhancement is marked as at risk for enhancement freeze
. Please keep the issue description up-to-date with appropriate stages as well. Thank you!
Hi @kannon92, checking in once more as we approach the 1.29 enhancement freeze deadline on 01:00 UTC Friday, 6th October 2023. The status of this enhancement is marked as at risk. It looks like https://github.com/kubernetes/enhancements/pull/4198 will address most of the requirements. Please make sure that the changes are merged in time. Let me know if I missed anything. Thanks!
Changes were merged so we hopefully should be good.
With KEP PR https://github.com/kubernetes/enhancements/pull/4198 approved, the enhancement is ready for the enhancements freeze. The status is now marked as tracked for enhancement freeze
for 1.29. π Thank you!
Hey there @kannon92! :wave:, v1.29 Docs Lead here. Does this enhancement work planned for v1.29 require any new docs or modification to existing docs? If so, please follows the steps here to open a PR against dev-1.29 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday, 19 October 2023. Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release. Thank you!
Hi again @kannon92! The deadline to open a placeholder PR against k/website for required documentation is this Thursday, 19 October. Could you please update me on the status of docs for this enhancement? Thank you!
This first alpha release wonβt have any corresponding doc changes yet.
Hi @kannon92 :wave: from the v1.29 Communications Release Team! We would like to check if you have any plans to publish blogs for this KEP regarding new features, removals, and deprecations for this release. If so, you need to open a PR placeholder in the website repository. The deadline will be on Tuesday 14th November 2023 (after the Docs deadline PR ready for review) Here's the 1.29 Calendar
Hey again @kannon92 π v1.29 Enhancements team here,
Just checking in as we approach code freeze at 01:00 UTC Wednesday 1st November 2023 .
Here's where this enhancement currently stands:
The status of this KEP is currently at risk for Code Freeze
. From what I understand, https://github.com/kubernetes/kubernetes/pull/120914 and https://github.com/kubernetes/kubernetes/pull/120616 are the code PRs that is planned for the v1.29
release. Please make sure that https://github.com/kubernetes/kubernetes/pull/120616 is merged in time for the code freeze.
As always, we are here to help if any questions come up. Thanks!
With https://github.com/kubernetes/kubernetes/pull/120616 this is now marked as tracked for code freeze
for 1.29! π
/remove-label lead-opted-in
Update for 1.30:
We are making good progress on the ecosystem (critools, crio and cadvisor PRs were merged). We need a cadvisor release to close out this implementation for alpha.
Will update https://github.com/kubernetes/kubernetes/pull/122438 to include cadvisor release when its available.
I have been working on e2e tests for image filesystem and I have started writing e2e configs for split disk.
Hello π 1.30 Enhancements Lead here,
I'm closing milestone 1.29 now,
If you wish to progress this enhancement in v1.30, please follow the instructions here to opt in the enhancement and make sure the lead-opted-in
label is set so it can get added to the tracking board and finally add /milestone v1.30
. Thanks!
/milestone clear
@mrunalp @SergeyKanzhelev could you add a milestone and opt in label for this feature?
Iβll be working on advisor bump and e2e tests in 1.30
/milestone v1.30 /stage alpha /label lead-opted-in
Hello @kannon92 π, Enhancements team here.
Just checking in as we approach enhancements freeze on Friday, February 9th, 2024 at 02:00 UTC.
This enhancement is targeting for stage alpha
for 1.30 (correct me, if otherwise)
Here's where this enhancement currently stands:
implementable
for latest-milestone: 1.30
. KEPs targeting stable
will need to be marked as implemented
after code PRs are merged and the feature gates are removed.For this KEP, we would just need to complete the following:
The status of this enhancement is marked as at risk for enhancement freeze
. Please keep the issue description up-to-date with appropriate stages as well. Thank you!
We don't need a PRR for this one. It is still staying in alpha and we had a brief one in the last release.
Main goal for this next stage is to get some dependencies changes and add e2e tests. So nothing changed from first PRR review.
Ah, ok! Sounds good - I'll mark this as tracked for enhancements freeze! Thanks for your quick response.
With all the requirements fulfilled this enhancement is now marked as tracked for the upcoming enhancements freeze π
Hello @kannon92 π, 1.30 Docs Lead here.
Does this enhancement work planned for 1.30 require any new docs or modification to existing docs?
If so, please follows the steps here to open a PR against dev-1.30
branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday February 22nd 2024 18:00 PDT.
Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release. Thank you!
Hi @kannon92
π from the v1.30 Communications Team! We'd love for you to opt in to write a feature blog about your enhancement!
We encourage blogs for features including, but not limited to: breaking changes, features and changes important to our users, and features that have been in progress for a long time and are graduating.
To opt in, you need to open a Feature Blog placeholder PR against the website repository. The placeholder PR deadline is 27th February, 2024. Here's the 1.30 Release Calendar
Hey again @kannon92 π Enhancements team here,
Just checking in as we approach code freeze at 02:00 UTC Wednesday 6th March 2024 .
Here's where this enhancement currently stands:
approved
and lgtm
labels applied) by the code freeze deadline. This includes tests.For this enhancement, it looks like the following PRs are open and need to be merged before code freeze:
Also, please let me know if there are other PRs in k/k we should be tracking for this KEP. As always, we are here to help if any questions come up. Thanks!
Hey @kannon92 - looks like the two above PRs merged! I'm seeing that https://github.com/kubernetes/kubernetes/pull/123518 has been added to the issue... code freeze is ~6 hours away. Do you think it will merge in time?
This is for test freeze. So I donβt think it should be tracked in code freeze.
Hello @kannon92 π , Enhancements team here.
With all the implementation(code related) PRs merged as per the issue description:
This enhancement is now marked as tracked for code freeze
for the v1.30
Code Freeze!
We hit a blocker with adding tests. It turns out that there is a fix in container/storage which crio uses for this work.
We are waiting for podman 5.0 to be released and then we can update crio to use the latest storage changes. We want to kick off a branch for 1.30 that does not include podman 5.0 changes so we are going to wait until 1.31 to get the e2e tests working.
So I will not be documenting this feature in a blog post because there is still some risk with the feature and I do not want to advertise the feature yet.
Kubelet changes are good as is. This is mainly a problem in the container runtime so we do not need any revert or anything.
Hi @kannon92 π, 1.31 Enhancements Lead here.
If you wish to progress this enhancement in v1.31, please have the SIG lead opt-in your enhancement by adding the lead-opted-in label and set the milestone to v1.31 before the Production Readiness Review Freeze.
/remove-label lead-opted-in
The Podman v5.0.0 has been released already a while ago:
Hi @mrunalp and @SergeyKanzhelev, would you be able to provide us here with the necessary tags?
Thank you for help in advance!
@kwilczynski even though podman v 5.0 is out, I think one needs to bump K8s version to use crio that corresponds to podman v5.0.
I tried to rerun the e2e tests failed and they still fail with the crio commit but I think this is expected. Podman v5.0 corresponds to crio 1.31.
For this feature what we are mostly waiting for is a bump in crio to 1.31 (hopefully we can do soon). And then hopefully e2e tests will work.
@kannon92, sounds good!
Aside from the Podman 5 release, you were waiting for a feature in containers/storage
βwas that for the CRI-O bump?
Currently, the main
and release-1.31
branches of CRI-O (the latter being a mirror of the main for now) have containers/storage
v1.54.0 included. This is the latest release (cut about two weeks ago at the time of writing).
@kannon92, was it this change we were waiting for in CRI-O?
This was release as part of v1.50.0 of containers/storage
, and CRI-O 1.30.x uses v1.51.0 already.
I think, I found the right change in containers/storage
:
There is also the following change:
@kannon92, we can backport this to an earlier version of CRI-O via our usual backport process if needed.
/retitle Kubelet support for Split Image Filesystem
@kwilczynski: Re-titling can only be requested by trusted users, like repository collaborators.
I was able to confirm that the Split Image Filesystem feature is working as expected per:
No issues while running with split container and image file system locations. :+1: :tada:
/label lead-opted-in /milestone v1.31
Hello everyone! I have opened a Pull Request to track this KEP's graduation to Beta:
/cc @kannon92 @mrunalp @SergeyKanzhelev @johnbelamaric
/stage beta
Hello @kannon92 π, Enhancements team here.
Just checking in as we approach enhancements freeze on 02:00 UTC Friday 14th June 2024 / 19:00 PDT Thursday 13th June 2024.
This enhancement is targeting stage beta
for v1.31 (correct me, if otherwise)
Here's where this enhancement currently stands:
implementable
for latest-milestone: v1.31
. KEPs targeting stable
will need to be marked as implemented
after code PRs are merged and the feature gates are removed.For this KEP, it looks like we still need to do the following:
latest-milestone: v1.31
for stage beta
by merging https://github.com/kubernetes/enhancements/pull/4684; this will also take care of the PRR review requirement, so this enhancement will be good to go after this.The status of this enhancement is marked as at risk for enhancement freeze
. Once the above PR is merged, we'll update the status.
If you anticipate missing enhancements freeze, you can file an exception request in advance. Thank you!
/assign
With https://github.com/kubernetes/enhancements/pull/4684 merged, we can mark this KEP as tracked for enhancements freeze
! π
/assign kwilczynski
Hello @kannon92 π, 1.31 Docs Shadow here.
Does this enhancement work planned for 1.31 require any new docs or modification to existing docs?
If so, please follows the steps here to open a PR against dev-1.31 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday June 27, 2024 18:00 PDT.
Also, take a look at Documenting for a release to get yourself familiarised with the docs requirement for the release.
Thank you!
Hi @bitoku @kannon92,
:wave: from the v1.31 Communications Team! We'd love for you to opt in to write a feature blog about your enhancement! Some reasons why you might want to write a blog for this feature include (but are not limited to) if this introduces breaking changes, is important to our users, or has been in progress for a long time and is graduating.
To opt in, let us know and open a Feature Blog placeholder PR against the website repository by 3rd July, 2024. For more information about writing a blog see the blog contribution guidelines.
Note: In your placeholder PR, use XX
characters for the blog date
in the front matter and file name. We will work with you on updating the PR with the publication date once we have a final number of feature blogs for this release.
@rashansmith, a blog post about this feature has already been written and published in the past. See:
Enhancement Description
One-line enhancement description (can be used as a release note): Kubelet can support ImageFilesystem being separated between writeable and read-only layer
Kubernetes Enhancement Proposal: https://github.com/kubernetes/enhancements/blob/master/keps/sig-node/4191-split-image-filesystem/README.md
Discussion Link: Garbage Collection Working group.
Primary contact (assignee): @kannon92
Responsible SIGs: sig-node
Enhancement target (which target equals to which milestone):
[x] Alpha - CRI Updates
k/enhancements
) update PR(s):k/k
) update PR(s):[x] Beta - container runtime support and ecosystem
[x] Code (
crio/crio
):https://github.com/cri-o/cri-o/pull/7401
https://github.com/cri-o/cri-o/pull/7269
[x] CAdvisor (
google/cadvisor
):https://github.com/google/cadvisor/pull/3395
[x] CRITools (
kubernetes-sigs/critools
):https://github.com/kubernetes-sigs/cri-tools/pull/1295
[x] Kubernetes (
kubernetes/kubernetes
):https://github.com/kubernetes/kubernetes/pull/122438
[x] Testing
[x] Docs (
k/website
) update PR(s):https://github.com/kubernetes/website/pull/46951
https://github.com/kubernetes/website/pull/43971
Blog post about Split Image Filesystem
[ ] Feedback
https://github.com/kubernetes/kubernetes/issues/126559
[ ] Stable
k/enhancements
) update PR(s):k/k
) update PR(s):k/website
) update(s): -->Nice to haves:
Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.