kubernetes / enhancements

Enhancements tracking repo for Kubernetes
Apache License 2.0
3.46k stars 1.49k forks source link

Support Volume Expansion Through StatefulSets #661

Open SidakM-zz opened 5 years ago

SidakM-zz commented 5 years ago

Enhancement Description

Please to keep this description up to date. This will help the Enhancement Team track efficiently the evolution of the enhancement

SidakM-zz commented 5 years ago

/kind feature /sig apps

janetkuo commented 5 years ago

@kubernetes/sig-apps-feature-requests

claurence commented 5 years ago

@SidakM - Hello I'm the enhancements lead for 1.14. It looks like this issue is targeting 1.14 for alpha can you let me know if that is still planned. Enhancements freeze is Jan 29th and we want all issues to have a KEP associated with them.

SidakM-zz commented 5 years ago

Hey @claurence , Was waiting for a review from @kubernetes/sig-apps-feature-requests . Not sure when one of them will look at it though.

k8s-ci-robot commented 5 years ago

@SidakM: Reiterating the mentions to trigger a notification: @kubernetes/sig-apps-feature-requests

In response to [this](https://github.com/kubernetes/enhancements/issues/661#issuecomment-454821839): >Hey @claurence , >Was waiting for a review from @kubernetes/sig-apps-feature-requests . Not sure when one of them will look at it though. > > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
claurence commented 5 years ago

@SidakM checking in as enhancements freeze is on Tuesday - was the KEP reviewed? Are there any open PRs to track for the 1.14 cycle?

SidakM-zz commented 5 years ago

@claurence Someone looked and commented but didn't follow up after so I am unsure where its at.

claurence commented 5 years ago

@SidakM since the KEP for this issue isn't merged yet we will be removing it from the 1.14 milestone. To have it added back in please file an exception - information on the exception process can be found here: https://github.com/kubernetes/sig-release/blob/master/releases/EXCEPTIONS.md

delgod commented 5 years ago

@claurence it is critical functionality for stateful applications like databases. If your run databases - you must to use StatefulSet. so currently, PVC resize feature is mostly useless without StatefulSet resize. please include it to 1.14 milestone.

claurence commented 5 years ago

@delgod because we have passed enhancement freeze and the KEP still is not merged please submit an exception request.

chino commented 5 years ago

Can we see something similar for DaemonSets?

kacole2 commented 5 years ago

I'm the Enhancement Lead for 1.15. Is this feature going to be graduating alpha/beta/stable stages in 1.15? Please let me know so it can be tracked properly and added to the spreadsheet. Enhancements do require a KEP as well.

Once coding begins, please list all relevant k/k PRs in this issue so they can be tracked properly.

justaugustus commented 5 years ago

/assign @SidakM

SidakM-zz commented 5 years ago

@gnufied Can we get this in for 1.15?

evillgenius75 commented 5 years ago

Hi @SidakM , I'm the 1.16 Enhancement Shadow. Is this feature going to be graduating alpha/beta/stable stages in 1.16? Please let me know so it can be added to the 1.16 Tracking Spreadsheet.

Once coding begins or if it already has, please list all relevant k/k PRs in this issue so they can be tracked properly.

As a reminder, every enhancement requires a KEP in an implementable state with Graduation Criteria explaining each alpha/beta/stable stages requirements merged into the k/e repo. The KEp is currently still open

Milestone dates are Enhancement Freeze 7/30 and Code Freeze 8/29.

Thank you.

archetec commented 5 years ago

Why is this feature request keeps getting pushed to one Enhancement to another...? This is very important, not only for databases but also for Kafka clusters in production! Although it's possible to replicate to a new cluster with more storage, and then swtich over, it's not a viable solution. We need this!

kacole2 commented 5 years ago

@archetec have you joined the meetings for SIG Apps and SIG Storage to see how this can be prioritized? So far, this is in infant stages because the KEP hasn't been approved. That means there is no community consensus for implementation of this feature.

archetec commented 5 years ago

@kacole2 I understand, and I just started to read about this... Please forgive my partial understanding of the process.

Reading comments on #660 it looks like there's a solution in review. But yes I see it's not approved yet, and looks like it's getting pushed to 1.17.

gnufied commented 5 years ago

@archetec the KEP has been approved but @SidakM was fine with moving it to 1.17 since getting the KEP merged within 1.16 time frame required requesting KEP exception. It is tricky feature and it is important to get the details right. We should have this implemented in 1.17.

kcmartin commented 5 years ago

Hello @SidakM -- 1.17 Enhancement Shadow here! 🙂

I wanted to reach out to see if this enhancement will be graduating to alpha/beta/stable in 1.17?

 Please let me know so that this enhancement can be added to 1.17 tracking sheet.

Thank you!

đź””Friendly Reminder

The current release schedule is

SidakM-zz commented 5 years ago

@kcmartin The goal is to graduate to alpha in 1.17. Waiting for api review. @gnufied

kcmartin commented 5 years ago

/milestone v1.17

kcmartin commented 5 years ago

Hi @SidakM We're only 5 days away from the Enhancements Freeze (Tuesday, October 15, EOD PST). Another friendly reminder that to be able to graduate this in the 1.17 release, KEP must have graduation criteria defined, in an implementable state, and merged in.

SidakM-zz commented 5 years ago

@gnufied As mentioned above the freeze is on Tuesday. Haven't heard back for the api review since I responded to the comments in the kep. Can we reach out for an update?

gnufied commented 5 years ago

@SidakM I agree with @liggitt that for the spec to be implementable - https://github.com/kubernetes/enhancements/pull/660#discussion_r325233794 comment needs to be addressed. As I understand it, this scenario can happen even if resize was successful and hence could prevent an user from rolling back.

kcmartin commented 5 years ago

Hey @SidakM / @gnufied , unfortunately deadline for 1.17 enhancement freeze has passed and looks like the KEP is still open. I will be removing this enhancement from the 1.17 milestone.

Please note that you can file an enhancement exception if you need to get this in for 1.17

/milestone clear

dudicoco commented 4 years ago

When will this feature finally be implemented? This would greatly improve stateful apps migration into k8s.

stanislavkozlovski commented 4 years ago

+1, much needed feature

johnbelamaric commented 4 years ago

Hey there @SidakM -- 1.18 Enhancements shadow here. I wanted to check in and see if you think this Enhancement will be implemented as alpha in 1.18?

The current release schedule is: Monday, January 6th - Release Cycle Begins Tuesday, January 28th EOD PST - Enhancements Freeze Thursday, March 5th, EOD PST - Code Freeze Monday, March 16th - Docs must be completed and reviewed Tuesday, March 24th - Kubernetes 1.18.0 Released

To be included in the release, this enhancement must have a merged KEP in the implementable status. The KEP must also have graduation criteria and a Test Plan defined. If you would like to include this enhancement, once coding begins please list all relevant k/k PRs in this issue so they can be tracked properly. đź‘Ť We'll be tracking enhancements here: http://bit.ly/k8s-1-18-enhancements Thanks!

kkmsft commented 4 years ago

@SidakM : wondering are you still working/interested in continuing to work on this ?

rtudo commented 4 years ago

+1 this should be very useful and important feature to have.

johnbelamaric commented 4 years ago

@janetkuo @SidakM I am on the enhancements team again for release 1.19. Any plans for this in 1.19?

johnbelamaric commented 4 years ago

@janetkuo @SidakM Ping! We need to track it in the release team if so - please let me know if there are any plans for this in 1.19.

Enhancements freeze is in one week, on May 19.

In order to be in the release this KEP will need:

Thanks!

johnbelamaric commented 4 years ago

@janetkuo @SidakM Enhancements freeze is tomorrow. To be included in the release the KEP will need to meet the above criteria by then.

fejta-bot commented 4 years ago

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /lifecycle stale

abraithwaite commented 4 years ago

/remove-lifecycle stale

kikisdeliveryservice commented 4 years ago

Hi @janetkuo @SidakM

Enhancements Lead here. Are there any plans for this 1.20?

Thanks! Kirsten

kikisdeliveryservice commented 4 years ago

Hi @janetkuo @SidakM

Following up: 1.20 Enhancements Freeze is October 6th. Could you let us know if you have plans for 1.20?

To be included in the milestone: The KEP must be merged in an implementable state The KEP must have test plans The KEP must have graduation criteria

Best, Kirsten

andyxning commented 4 years ago

/sub

andyxning commented 4 years ago

As we are evolving to support resize in-use PVC, i think we need to support StatefulSet PVC change.

piyushkumar13 commented 3 years ago

@SidakM-zz Any ETA on the availability of this feature ?

fejta-bot commented 3 years ago

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale

yfoelling commented 3 years ago

/remove-lifecycle stale

fejta-bot commented 3 years ago

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale

fejta-bot commented 3 years ago

Stale issues rot after 30d of inactivity. Mark the issue as fresh with /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten

abraithwaite commented 3 years ago

/remove-lifecycle rotten

k8s-triage-robot commented 3 years ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

m-yosefpor commented 3 years ago

/remove-lifecycle stale

akki-9922 commented 2 years ago

Hi, Can we know when this is expected to deliver where STS will support PVC resize?

Priyankasaggu11929 commented 2 years ago

Hello @janetkuo @SidakM đź‘‹, 1.24 Enhancements team here.

Just checking in as we approach enhancements freeze on 18:00pm PT on Thursday Feb 3rd, 2022. This enhancement is targeting alpha for 1.24 and https://github.com/kubernetes/enhancements/pull/2842 is the latest KEP PR, is that correct?

Here’s where this enhancement currently stands:

The status of this enhancement is track as at risk. Please update this issue description with appropriate stages as well. Thank you!