search

kubesphere-sigs / ks

ks is a tool that makes it be easy to work with KubeSphere.
MIT License
22 stars 16 forks source link

Fix the version check when install ks with kubekey #232

Closed LinuxSuRen closed 2 years ago

codecov[bot] commented 2 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@3f8ecfc). Click here to learn what that means. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #232   +/-   ##
=========================================
  Coverage          ?   10.54%           
=========================================
  Files             ?       33           
  Lines             ?     1451           
  Branches          ?        0           
=========================================
  Hits              ?      153           
  Misses            ?     1285           
  Partials          ?       13
Flag Coverage Δ
unittests 10.54% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3f8ecfc...eab8623. Read the comment docs.

LinuxSuRen commented 2 years ago

Although it doesn't work by default because kks released don't support prerelease version currently, the change looks good to me.

You can install it via: hd install kubekey --accept-preReleas

JohnNiang commented 2 years ago

Although it doesn't work by default because kks released don't support prerelease version currently, the change looks good to me.

You can install it via: hd install kubekey --accept-preRelease

Thank you for your reminder. I'm going to try it out.