search

kubesphere-sigs / ks

ks is a tool that makes it be easy to work with KubeSphere.
MIT License
22 stars 16 forks source link

Migrate SonarQube configuration from kubesphere-config into devops-config #245

Closed JohnNiang closed 3 years ago

JohnNiang commented 3 years ago

What this PR dose

Migrate SonarQube configuration from kubesphere-config into devops-config.

Why we need it

Please see

Which issue this PR fixes

Fix https://github.com/kubesphere/ks-devops/issues/385

Steps to test

  1. Add SonarQube configuration part into ConfigMap kubesphere-config

    sonarQube:
  host: http://sonarqube-sonarqube.kubesphere-devops-system:9000
  token: 4dbc5fcaad6a4fd3780fbdde53804cb251e6d2ce

  2. Check ConfigMap devops-config

  3. Run the command 

    go run ./kubectl-plugin/kubectl-ks.go option migrate --service devops-apiserver.kubesphere-devops-system:9090 --namespace kubesphere-devops-system

  4. Check ConfigMap devops-config again, especially SonarQube configuration part

/kind bug

ks-ci-bot commented 3 years ago

@JohnNiang: The label(s) kind/bug cannot be applied, because the repository doesn't have them.

In response to [this](https://github.com/kubesphere-sigs/ks/pull/245): >### What this PR dose > >Migrate SonarQube configuration from kubesphere-config into devops-config. > >### Why we need it > >Please see >- https://github.com/kubesphere/ks-devops/issues/385 > >### Which issue this PR fixes > >Fix https://github.com/kubesphere/ks-devops/issues/385 > >### Steps to test > >1. Add SonarQube configuration part into ConfigMap `kubesphere-config` > > ```yaml > sonarQube: > host: http://sonarqube-sonarqube.kubesphere-devops-system:9000 > token: 4dbc5fcaad6a4fd3780fbdde53804cb251e6d2ce > ``` > >1. Check ConfigMap `devops-config` > >1. Run the command > > ```bash > go run ./kubectl-plugin/kubectl-ks.go option migrate --service devops-apiserver.kubesphere-devops-system:9090 --namespace kubesphere-devops-system > ``` > >1. Check ConfigMap `devops-config` again, especially `SonarQube` configuration part > >/kind bug > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
codecov[bot] commented 3 years ago

Codecov Report

Merging #245 (6798e14) into master (f362378) will decrease coverage by 0.78%. The diff coverage is 12.06%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #245      +/-   ##
==========================================
- Coverage   10.92%   10.14%   -0.79%     
==========================================
  Files          33       36       +3     
  Lines        1455     1636     +181     
==========================================
+ Hits          159      166       +7     
- Misses       1285     1456     +171     
- Partials       11       14       +3
Flag Coverage Δ
unittests 10.14% <12.06%> (-0.79%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
kubectl-plugin/install/kk.go 13.74% <0.00%> (ø)
kubectl-plugin/config/migrate.go 6.66% <12.28%> (ø)
kubectl-plugin/config/config_root.go 0.00% <0.00%> (ø)
kubectl-plugin/config/cluster.go 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e1d85c3...6798e14. Read the comment docs.

ks-ci-bot commented 3 years ago

@LinuxSuRen: The label(s) tide/merge-method-squash cannot be applied, because the repository doesn't have them.

In response to [this](https://github.com/kubesphere-sigs/ks/pull/245#pullrequestreview-819847883): >/approve >/label tide/merge-method-squash Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
ks-ci-bot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang, LinuxSuRen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubesphere-sigs/ks/blob/master/OWNERS)~~ [LinuxSuRen] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
LinuxSuRen commented 3 years ago

/lgtm