kubevirt / containerdisks

Officially built and maintained containerdisks of the KubeVirt project
https://quay.io/containerdisks
Apache License 2.0
25 stars 22 forks source link

opensuse: Add default instance type and preference ENV vars #147

Closed lyarwood closed 2 months ago

lyarwood commented 2 months ago

/hold /cc @0xFelix

What this PR does / why we need it:

With https://github.com/kubevirt/common-instancetypes/pull/193 in place we can now provide default instance types and prefrences for the recently introduced OpenSUSE containerdisks.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #

Special notes for your reviewer:

Release note:

ENV variables for default instance types and preferences have been added to the `amd64` OpenSUSE Tumbleweed and Leap containerdisks.
kubevirt-bot commented 2 months ago

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

lyarwood commented 2 months ago

/hold cancel

kubevirt-bot commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 0xFelix

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubevirt/containerdisks/blob/main/OWNERS)~~ [0xFelix] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment