search

kubevirt / containerdisks

Officially built and maintained containerdisks of the KubeVirt project
https://quay.io/containerdisks
Apache License 2.0
29 stars 24 forks source link

Add s390x Artifacts #182

Closed Rurouni-Jiaxin closed 1 week ago

Rurouni-Jiaxin commented 3 months ago

What this PR does / why we need it:

I create this PR as part of the bigger effort to enable KubeVirt on s390x, a.k.a IBM Z ( please refer to : https://github.com/kubevirt/kubevirt/pull/10490 ). It appears that https://github.com/kubevirt/common-instancetypes/ depends on containerdisks.

Therefore I added "s390x" entries to existing Feodora, CentOS Stream and Ubuntu Artifact / registries.

I have not added any tests to either artifacts/fedora/fedora_test.go , artifacts/centosstream/centos-stream_test.go, or artifacts/ubuntu/ubuntu_test.go, because the tests appears to only verify the parsing function.

TO DO:

Discuss whether other Linux distros, e.g. OpenSUSE is needed for s390x.

Special notes for your reviewer:

Release note:

kubevirt-bot commented 3 months ago

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
kubevirt-bot commented 3 months ago

Hi @Rurouni-Jiaxin. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
kubevirt-bot commented 3 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign dominikholler for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubevirt/containerdisks/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
jcanocan commented 3 months ago

@Rurouni-Jiaxin Thanks for your PR! Could you please add a description to your commit and sign it off?

Rurouni-Jiaxin commented 3 months ago

Hi! Thanks for your contribution!

You are right that the unit tests are mainly focused on parsing data returned from the mirrors. Nonetheless, can you please add unit tests for s390x in the artifacts you touched? (fedora, centosstream and ubuntu). Opensuse does not ship cloud images for s390x, so it is okay to leave it out.

Are you going to add s390x preferences to common-instancetypes soon? Otherwise I would like to ask you to remove the instancetypes/preferences from the images env variables for now.

We don't have automated testing for aarch64 artifacts yet but we're looking to add that in the future. Would you be able to provide resources to automate the testing of s390x artifacts?

Last question: Did you verify the newly created containerdisks are able to boot in your local environment?

Regarding s390x resources, I assume by looking at the nodeSelector in these ProwJobs, that bare metal servers are required. Such resources would be available on s390x, but it will take time.

kubevirt-bot commented 2 months ago

Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits.

:memo: Please follow instructions in the contributing guide to update your commits with the DCO

Full details of the Developer Certificate of Origin can be found at developercertificate.org.

The list of commits missing DCO signoff:

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
Rurouni-Jiaxin commented 2 months ago

Still testing on my local s390x environment

Rurouni-Jiaxin commented 2 months ago

/hold

kubevirt-bot commented 1 week ago

PR needs rebase.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
lyarwood commented 1 week ago

Closing as https://github.com/kubevirt/containerdisks/pull/203 has now landed introducing centos stream and ubuntu artefacts, please feel to rebase and reopen if you want to use this PR to add more.