search

kubevirt / containerdisks

Officially built and maintained containerdisks of the KubeVirt project
https://quay.io/containerdisks
Apache License 2.0
29 stars 24 forks source link

Add s390x support for Fedora artifact #224

Closed aditi-sharma-1 closed 1 week ago

aditi-sharma-1 commented 1 week ago

This pull request adds s390x architecture support for the Fedora artifact in the Containerdisks repository. These changes ensure compatibility, enabling support for s390x alongside existing platforms.

Release note:

Add s390x artifact

Signed-off-by: Aditi Sharma Aditi.Sharma@ibm.com

kubevirt-bot commented 1 week ago

Hi @aditi-sharma-1. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
0xFelix commented 1 week ago

/test all

aditi-sharma-1 commented 1 week ago

Looks good to me. Not sure the nil assignments to EnvVariables should be dropped for now.

/test all

Hi @0xFelix,

Thank you for the review! The nil assignments to the EnvVariables are working well and have not caused any issues on s390x. We also used this locally built Fedora image for downstream OCP-Virt tier-0 local testing, and it was successful.

Please let me know your thoughts. Thank you!

kubevirt-bot commented 1 week ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 0xFelix

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubevirt/containerdisks/blob/main/OWNERS)~~ [0xFelix] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
aditi-sharma-1 commented 1 week ago

Hi @0xFelix, Yes, we plan to update this once the common-instancetypes for s390x are available. Thank you!

lyarwood commented 1 week ago

/lgtm