search

kubevirt / vm-import-operator

Operator for importing VMs from RHV to KubeVirt
Apache License 2.0
16 stars 23 forks source link

Use VM UUID and disk key to name DataVolumes for vSphere VMs #448

Closed mansam closed 3 years ago

mansam commented 3 years ago

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1898840

Signed-off-by: Sam Lucidi slucidi@redhat.com

kubevirt-bot commented 3 years ago

@mansam: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
ghost commented 3 years ago

/retest

kubevirt-bot commented 3 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: fdupont-redhat, mansam, pkliczewski To complete the pull request process, please assign You can assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubevirt/vm-import-operator/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
mansam commented 3 years ago

Something's wrong here, It looks like Prow actually failed, but github sees it as success? Please do not merge until this is resolved.

mansam commented 3 years ago

These tests seem to be passing locally. Retesting.

/retest

mansam commented 3 years ago

Prow failed in 11 seconds again though still showing green, with the following message:

 + /home/prow/go/src/github.com/kubevirt/vm-import-operator/_kubevirtci/cluster-up/up.sh
Download the image docker.io/kubevirtci/k8s-1.18@sha256:906af927cd0a998166d12c61162db2a0eb395c9e65d537ce7d1af2d603cb8690
Downloading ...................................................................................................
{"component":"entrypoint","file":"prow/entrypoint/run.go:168","func":"k8s.io/test-infra/prow/entrypoint.Options.ExecuteProcess","level":"error","msg":"Entrypoint received interrupt: terminated","severity":"error","time":"2020-12-10T17:29:16Z"}

I have no idea what the cause of that would be. @pkliczewski have you seen a CI failure like this before?

pkliczewski commented 3 years ago

I have no idea what the cause of that would be. @pkliczewski have you seen a CI failure like this before?

No. Looks very strange