kubevirt / vm-import-operator

Operator for importing VMs from RHV to KubeVirt
Apache License 2.0
16 stars 23 forks source link

Mount block devices properly on the virt-v2v container #464

Closed mansam closed 3 years ago

mansam commented 3 years ago

Block devices need to be mounted as VolumeDevices rather than VolumeMounts, otherwise the pod will get stuck in ContainerCreating because the volumes can't be attached.

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1917908

Signed-off-by: Sam Lucidi slucidi@redhat.com

kubevirt-bot commented 3 years ago

@mansam: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
ghost commented 3 years ago

/retest

mansam commented 3 years ago

/retest

pkliczewski commented 3 years ago

/retest

mansam commented 3 years ago

/retest

pkliczewski commented 3 years ago

@mansam please rebase

mansam commented 3 years ago

/retest

mansam commented 3 years ago

The test that's most consistently failing is an oVirt test which is checking to ensure that the VM is deleted when the import fails. It's attempting to get the VM from the API and expecting to see a NotFound error, but it doesn't. My best guess at the moment is that it's hung up on some finalizer, but I am still trying to debug it. In any case, the failure should not be related to this PR.

/retest

kubevirt-bot commented 3 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mansam, pkliczewski To complete the pull request process, please assign You can assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubevirt/vm-import-operator/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment