search

kubevirt / vm-import-operator

Operator for importing VMs from RHV to KubeVirt
Apache License 2.0
16 stars 23 forks source link

[BZ 1945121] Update storage overhead formula #479

Closed ghost closed 3 years ago

ghost commented 3 years ago

It seems that the formula should be roundup(size/(1-overhead), 512). Rounding integers doesn't work with math.Round. I've also changed the overhead values to use real numbers that have been calculated separately.

[BZ 1945121] Fix overhead calculation formula to match CDI.
sonarcloud[bot] commented 3 years ago

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

kubevirt-bot commented 3 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: fdupont-redhat, mansam To complete the pull request process, please assign You can assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubevirt/vm-import-operator/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
ghost commented 3 years ago

/retest

awels commented 3 years ago

/lgtm

awels commented 3 years ago

/test pull-vm-import-operator-e2e-k8s-1.18

ghost commented 3 years ago

/retest

ghost commented 3 years ago

/test pull-vm-import-operator-e2e-k8s-1.18

ghost commented 3 years ago

It's Good Friday today, so I'll merge my own PR since it's been approved.