kuujo / vertigo

Flow-based programming for the Vert.x application platform.
Apache License 2.0
155 stars 24 forks source link

JSON Defined Network Issues #26

Open joshuamorris3 opened 10 years ago

joshuamorris3 commented 10 years ago

I found a few differences between the example given in the documentation for Defining networks in JSON (https://github.com/kuujo/vertigo/wiki/Java-User-Manual#defining-networks-in-json) and what is implemented. I was using version 0.6.1 with the Java API.

  1. Component address - The JSON structure notes and example uses the component key as the address, however this does not work. Instead I had to put an address key for the component. Also when debugging what it was doing without the address key, it had in its place a GUID like value.
  2. Input stream - I found that for the worker it would not work without a stream value in JSON. When I debugged this the value was null.
  3. Input grouping - This was also required in JSON for the worker to work. When I debugged this the value was null. Also the documentation example has the full class name of the grouping class, whereas the structure documentation and the implemented solution takes the short name.
  4. Input id - I found when debugging this the input id was null. When I compared this with a network worker created programmatically the id had a GUID like value.

To figure out the above I compared the JSON created network with a programmatically created network. The programmatic version worked fine and created the defaults as expected.