Closed andredasilvapinto closed 11 years ago
Agree on the failHandler
naming. Also, you are absolutely correct that the AbstractExecutor
appears to be calling the wrong handler. Obviously I missed that when I added the timeoutHandler
to the executors. No integration tests have been written for executor timeouts and such. Perhaps I should get on that to catch these types of issues.
Thanks
Shouldn't AbstractExecutor.enqueue() timer handler use timeoutHandler instead of failHandler?
I would also suggest changing DefaultHeartBeatMonitor.listen() argument and DefaultHeartBeatMonitor.AddressMonitor property name from failHandler to timeoutHandler. I know it is defined in AbstractCoordinator.doRegister and is a different kind of timeout handler, but I find the name more suitable than a generic "failHandler".