Open kvark opened 7 years ago
Well, here it is the checklist for this issue.
as_
, to_
, into_
conventions ([C-CONV])iter
, iter_mut
, into_iter
([C-ITER])_mut
and _ref
([C-OWN-SUFFIX])Copy
, Clone
, Eq
, PartialEq
, Ord
, PartialOrd
, Hash
Debug
,
Display
, Default
From
, AsRef
, AsMut
([C-CONV-TRAITS])FromIterator
and Extend
([C-COLLECT])Serialize
, Deserialize
([C-SERDE])"serde"
cfg option that enables Serde ([C-SERDE-CFG])Send
and Sync
where possible ([C-SEND-SYNC])Send
and Sync
([C-SEND-SYNC-ERR])()
([C-MEANINGFUL-ERR])Hex
, Octal
, Binary
formatting ([C-NUM-FMT])?
, not try!
, not unwrap
([C-QUESTION-MARK])Pointer
and WeakPointer
aren't smart pointers, so we have downgrade
and upgrade
.Deref
and DerefMut
([C-DEREF])Deref
and DerefMut
never fail ([C-DEREF-FAIL])bool
or Option
([C-CUSTOM-TYPE])bitflags
, not enums ([C-BITFLAG])Debug
([C-DEBUG])Debug
representation is never empty ([C-DEBUG-NONEMPTY])
https://github.com/brson/rust-api-guidelines