search

kwonoj / cld3-asm

WebAssembly based Javascript bindings for google Compact Language Detector v3
MIT License
56 stars 7 forks source link

feat(cldloader): use cwrap interface, disable dynamic execution #124

Closed kwonoj closed 5 years ago

kwonoj commented 5 years ago

This PR disables dynamic execution of preamble, also enables SINGLE_FILE.

codecov[bot] commented 5 years ago

Codecov Report

Merging #124 into master will decrease coverage by 40.27%. The diff coverage is 48.21%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #124       +/-   ##
===========================================
- Coverage     100%   59.72%   -40.28%     
===========================================
  Files           4        5        +1     
  Lines          44       72       +28     
  Branches        5        3        -2     
===========================================
- Hits           44       43        -1     
- Misses          0       27       +27     
- Partials        0        2        +2
Impacted Files Coverage Δ
src/wrapCldInterface.ts 100% <100%> (ø)
src/cldLoader.ts 41.3% <41.3%> (-58.7%) :arrow_down:
src/loadModule.ts 85.71% <77.77%> (-14.29%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update afe8f11...ca0cffc. Read the comment docs.

codecov[bot] commented 5 years ago

Codecov Report

Merging #124 into master will decrease coverage by 40.27%. The diff coverage is 48.21%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #124       +/-   ##
===========================================
- Coverage     100%   59.72%   -40.28%     
===========================================
  Files           4        5        +1     
  Lines          44       72       +28     
  Branches        5        3        -2     
===========================================
- Hits           44       43        -1     
- Misses          0       27       +27     
- Partials        0        2        +2
Impacted Files Coverage Δ
src/wrapCldInterface.ts 100% <100%> (ø)
src/cldLoader.ts 41.3% <41.3%> (-58.7%) :arrow_down:
src/loadModule.ts 85.71% <77.77%> (-14.29%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update afe8f11...ca0cffc. Read the comment docs.