kyma-project / cli

Simple set of commands to manage a Kyma installation
Apache License 2.0
112 stars 118 forks source link

Extend input parameters for `alpha hana map` command #2225

Closed kwiatekus closed 1 week ago

kwiatekus commented 1 month ago

Description: An enhancement to the alpha hana map command is needed. Currently, the command assumes that both hana-cloud and hana-admin-access service instances are available from the kyma runtime context via btp-operator, however this is not the common setup. Usually those instances live outside of the runtime context. Therefore the command should support passing a JSON file containing service binding credentials for the HANA's Admin Access API service instance. This feature would greatly simplify the process of configuring access to the HANA service, especially for users who separate their SAP Hana instances from the disposable kyma runtime context.

AC: Add a new, required input parameter (e.g., --credentials-file or ) to the alpha hana map command.

Impact: This change will introduce a new required parameter and should replace the mechanism of creating HANA Admin Access API service instance via btp-operator. As explained in the description, having hana instance in the runtime context makes no sense (runtime is disposable but hana is stateful) and therefore it is not necessary to maintain backward compatibility.

Attachments hana admin api access usage in sample pipeline

kwiatekus commented 4 weeks ago

depends on https://github.com/kyma-project/cli/issues/2228

kwiatekus commented 2 weeks ago

The command should be available when kubeconfig is known to a cluster. The command should resolve cluster_id from kyma-system/sap-btp-manager secret, and send it as part of POST payload to create hana instance mapping