Closed kyriv1980 closed 3 months ago
@moose-ncrc commented at Sep 14, 2020 12:18PM MST:
In GitLab by @moosetest on Sep 14, 2020, 13:18
Job Test on 71a0e3e wanted to post the following:
Code coverage: deleted
This comment will be updated on new commits.
@moose-ncrc commented at Sep 14, 2020 12:27PM MST:
In GitLab by @moosetest on Sep 14, 2020, 13:27
CIVET Testing summary for a86dc76
Precheck : Passed
Test : Failed : test subchannel
Test dbg : Failed : test subchannel
Non unity build : Passed
@moose-ncrc commented at Sep 15, 2020 11:12AM MST:
In GitLab by @kyriv1980 on Sep 15, 2020, 12:12
added 1 commit
@moose-ncrc commented at Sep 15, 2020 11:13AM MST:
In GitLab by @moosetest on Sep 15, 2020, 12:13
CIVET Testing summary for fe23703
Precheck : Failed : pre test
Test : Canceled by user
Test dbg : Canceled by user
Non unity build : Canceled by user
@moose-ncrc commented at Sep 17, 2020 08:19AM MST:
In GitLab by @andrsd on Sep 17, 2020, 09:19
Drop commit fe237030
. That's not how IDE are supported on repo level. For one, there are paths that are valid only on your machine. That venv
stuff should be activate by users if they decide to use it. Should not be part of the repo.
@moose-ncrc commented at Sep 17, 2020 01:55PM MST:
In GitLab by @kyriv1980 on Sep 17, 2020, 14:55
added 1 commit
@moose-ncrc commented at Sep 17, 2020 01:57PM MST:
In GitLab by @kyriv1980 on Sep 17, 2020, 14:57
I deleted the offending folder altogether
@moose-ncrc commented at Sep 17, 2020 02:25PM MST:
In GitLab by @moosetest on Sep 17, 2020, 15:25
CIVET Testing summary for fb59ae5
Precheck : Passed
Test : Failed : test subchannel
Test dbg : Failed : test subchannel
Non unity build : Passed
@moose-ncrc commented at Sep 17, 2020 06:31PM MST:
In GitLab by @kyriv1980 on Sep 17, 2020, 19:31
added 1 commit
@moose-ncrc commented at Sep 17, 2020 07:04PM MST:
In GitLab by @moosetest on Sep 17, 2020, 20:04
CIVET Testing summary for 8938aa6
Precheck : Passed
Test : Failed : test subchannel
Test dbg : Failed : test subchannel
Non unity build : Passed
@moose-ncrc commented at Sep 18, 2020 07:33AM MST:
In GitLab by @andrsd on Sep 18, 2020, 08:33
Looks like you broke something - 2 tests are crashing with segfault.
So log into hpclogin
, then go to either sawtooth or lemhi, build your code in debug mode and run the test via debugger to find it out...
@moose-ncrc commented at Sep 22, 2020 10:28AM MST:
In GitLab by @kyriv1980 on Sep 22, 2020, 11:28
added 1 commit
@moose-ncrc commented at Sep 22, 2020 10:54AM MST:
In GitLab by @moosetest on Sep 22, 2020, 11:54
CIVET Testing summary for d99a3d1
Precheck : Passed
Test : Failed : test subchannel
Test dbg : Failed : test subchannel
Non unity build : Passed
@moose-ncrc commented at Sep 22, 2020 12:33PM MST:
In GitLab by @kyriv1980 on Sep 22, 2020, 13:33
added 1 commit
@moose-ncrc commented at Sep 22, 2020 01:01PM MST:
In GitLab by @moosetest on Sep 22, 2020, 14:01
CIVET Testing summary for 346e544
Precheck : Passed
Test : Failed : test subchannel
Test dbg : Failed : test subchannel
Non unity build : Passed
@moose-ncrc commented at Sep 25, 2020 01:22PM MST:
In GitLab by @kyriv1980 on Sep 25, 2020, 14:22
added 1 commit
@moose-ncrc commented at Sep 25, 2020 01:53PM MST:
In GitLab by @moosetest on Sep 25, 2020, 14:53
CIVET Testing summary for 56a47f8
Precheck : Passed
Test : Failed : test subchannel
Test dbg : Canceled by user
Non unity build : Canceled by user
@moose-ncrc commented at Sep 25, 2020 06:59PM MST:
In GitLab by @kyriv1980 on Sep 25, 2020, 19:59
added 1 commit
@moose-ncrc commented at Sep 25, 2020 07:28PM MST:
In GitLab by @moosetest on Sep 25, 2020, 20:28
CIVET Testing summary for 1c383d1
Precheck : Passed
Test : Failed : generate code coverage
Test dbg : Failed : test subchannel
Non unity build : Passed
@moose-ncrc commented at Oct 12, 2020 12:10PM MST:
In GitLab by @kyriv1980 on Oct 12, 2020, 13:10
added 1 commit
@moose-ncrc commented at Oct 12, 2020 12:23PM MST:
In GitLab by @kyriv1980 on Oct 12, 2020, 13:23
added 1 commit
@moose-ncrc commented at Oct 12, 2020 12:23PM MST:
In GitLab by @moosetest on Oct 12, 2020, 13:23
CIVET Testing summary for 62f7147
Precheck : Canceled by user
Test : Canceled by user
Test dbg : Canceled by user
Non unity build : Canceled by user
@moose-ncrc commented at Oct 12, 2020 12:34PM MST:
In GitLab by @kyriv1980 on Oct 12, 2020, 13:34
added 1 commit
@moose-ncrc commented at Oct 12, 2020 12:34PM MST:
In GitLab by @moosetest on Oct 12, 2020, 13:34
CIVET Testing summary for 4eecafe
Precheck : Canceled by user
Test : Canceled by user
Test dbg : Canceled by user
Non unity build : Canceled by user
@moose-ncrc commented at Oct 12, 2020 01:14PM MST:
In GitLab by @kyriv1980 on Oct 12, 2020, 14:14
added 1 commit
@moose-ncrc commented at Oct 12, 2020 01:14PM MST:
In GitLab by @moosetest on Oct 12, 2020, 14:14
CIVET Testing summary for 75a60e8
Precheck : Canceled by user
Test : Canceled by user
Test dbg : Canceled by user
Non unity build : Canceled by user
@moose-ncrc commented at Oct 12, 2020 01:26PM MST:
In GitLab by @kyriv1980 on Oct 12, 2020, 14:26
added 1 commit
@moose-ncrc commented at Oct 12, 2020 01:26PM MST:
In GitLab by @moosetest on Oct 12, 2020, 14:26
CIVET Testing summary for 2dba642
Precheck : Passed
Test : Canceled by user
Test dbg : Canceled by user
Non unity build : Canceled by user
@moose-ncrc commented at Oct 12, 2020 02:07PM MST:
In GitLab by @moosetest on Oct 12, 2020, 15:07
CIVET Testing summary for c7d582b
Precheck : Passed
Test : Failed : generate code coverage
Test dbg : Failed : test subchannel
Non unity build : Passed
@moose-ncrc commented at Oct 15, 2020 12:08PM MST:
In GitLab by @andrsd on Oct 15, 2020, 13:08
what is this file for?
@moose-ncrc commented at Oct 15, 2020 12:08PM MST:
In GitLab by @andrsd on Oct 15, 2020, 13:08
I am assuming that the content of Python_Code
is the python version of subchannel. I don't want that in this repo. You can try to convince me that we need it, though :-)
@moose-ncrc commented at Oct 15, 2020 12:08PM MST:
In GitLab by @andrsd on Oct 15, 2020, 13:08
I don't think this was supposed to be part of this MR. The path is specific to your machine...
@moose-ncrc commented at Oct 15, 2020 12:08PM MST:
In GitLab by @andrsd on Oct 15, 2020, 13:08
Looks like this is using bunch of PSBT data. I though you said the data was not really publicly available, so you should not be adding those here.
@moose-ncrc commented at Oct 15, 2020 12:08PM MST:
In GitLab by @andrsd on Oct 15, 2020, 13:08
Should name this _soln_old
- that follows the MOOSE code standard better.
@moose-ncrc commented at Oct 15, 2020 12:08PM MST:
In GitLab by @andrsd on Oct 15, 2020, 13:08
probably should not be part of this MR - includes your-machine-specific stuff
@moose-ncrc commented at Oct 15, 2020 12:08PM MST:
In GitLab by @andrsd on Oct 15, 2020, 13:08
member variables should start with _
@moose-ncrc commented at Oct 15, 2020 12:08PM MST:
In GitLab by @andrsd on Oct 15, 2020, 13:08
weird Capitalization
@moose-ncrc commented at Oct 15, 2020 12:08PM MST:
In GitLab by @andrsd on Oct 15, 2020, 13:08
Probably a left over. We said that output will be done via Outputs system, if users are interested in matrices, etc. In general, do not pollute the terminal with debug outputs. Just because you need it right now is not a reason to justify having it in merged in the devel and then master.
@moose-ncrc commented at Oct 15, 2020 12:08PM MST:
In GitLab by @andrsd on Oct 15, 2020, 13:08
Should we make this tolerance an input parameter? Don't have to do this in the MR. Just wondering...
@moose-ncrc commented at Oct 15, 2020 12:08PM MST:
In GitLab by @andrsd on Oct 15, 2020, 13:08
There is also lots of commented out blocks in input file. That should be cleaned up.
@moose-ncrc commented at Oct 15, 2020 12:09PM MST:
In GitLab by @andrsd on Oct 15, 2020, 13:09
And there are these Wij_global
files. What are they for?
@moose-ncrc commented at Oct 15, 2020 12:12PM MST:
In GitLab by @andrsd on Oct 15, 2020, 13:12
And last thing. The MR failed, because the code coverage dropped below 80%. Did we disable some test? The pretty mesh related stuff is not being currently tested...
@moose-ncrc commented at Oct 15, 2020 05:21PM MST:
In GitLab by @kyriv1980 on Oct 15, 2020, 18:21
changed this line in version 14 of the diff
@moose-ncrc commented at Oct 15, 2020 05:21PM MST:
In GitLab by @kyriv1980 on Oct 15, 2020, 18:21
added 1 commit
@moose-ncrc commented at Oct 15, 2020 05:23PM MST:
In GitLab by @kyriv1980 on Oct 15, 2020, 18:23
I assume this file has been created automatically by the IDE. Since I've been using an IDE for debugging. I have no idea what this does.
@moose-ncrc commented at Oct 15, 2020 05:24PM MST:
In GitLab by @kyriv1980 on Oct 15, 2020, 18:24
No we don't need it. I have made another repo where I put the Python stuff. In the last push I have deleted this folder altogether.
@moose-ncrc commented at Oct 15, 2020 05:28PM MST:
In GitLab by @kyriv1980 on Oct 15, 2020, 18:28
Again, I think this is an IDE related file. I should be able to make git ignore the files that make sense only in my local machine.
@moose-ncrc commented at Oct 15, 2020 05:31PM MST:
In GitLab by @kyriv1980 on Oct 15, 2020, 18:31
Actually the PSBT data that describe experimental facility/geometry are open to the public. So everything in the input file is publicly available. What I don't want to share are experimental results which I haven't.
@moose-ncrc commented at Oct 15, 2020 05:33PM MST:
In GitLab by @kyriv1980 on Oct 15, 2020, 18:33
Done.
@moose-ncrc commented at Oct 15, 2020 05:36PM MST:
In GitLab by @kyriv1980 on Oct 15, 2020, 18:36
Done.
Imported from https://github.inl.gov/ncrc/subchannel/issues/78 : @moose-ncrc created issue at Sep 14, 2020 11:57AM MST:
In GitLab by @kyriv1980 on Sep 14, 2020, 12:57
_Merges makemodular -> devel
Closes issue #8