search

lab-64 / split-the-bill-client

Flutter App for easy and fast splitting up of receipts
4 stars 0 forks source link

69: Group invitation #116

Closed GR0ZA closed 4 months ago

GR0ZA commented 4 months ago

Right now if a user already is a member of a group and tries to join the group, we show a success message. We rather should show some warning "u are already member of this group" but for that we need an adjustment in backend first.

It's rather a temporary solution but we'll keep it like this until deep links are implemented.

Closes #69

Morvvvv commented 4 months ago

Does Share support automatically copying it? If so, this would make it easier. Also, you send the other User a whole message, but the user has to "cut" out only the important part. Do you want to implement it, so that they can just copy the message or the id?

GR0ZA commented 4 months ago

Does Share support automatically copying it? If so, this would make it easier. Also, you send the other User a whole message, but the user has to "cut" out only the important part. Do you want to implement it, so that they can just copy the message or the id?

If I understood you properly:

  1. There is this icon that allows you to copy the message: image

  2. The Share package we are using doesn't support more than one message that can be shared. So it either has to be message with the context or just the Invitation ID. On one hand as you mentioned it's stupid that as a receiver u have to cut out the important part. On the other hand it's not so great when there is no context and just the plain ID. No good solution here :D As it's just a temporary solution I wouldn't think for too long about it. I can easily change it to plain ID if you think it's better. I have no opinion on that.

Morvvvv commented 4 months ago

I think I didn't explain it propery, sry.

  1. Is there an Option that does this instantly, without clicking that button? That would save a click and be more fluid. (Totally not necessary)

  2. I meant it the other way around. We can share the message, but if the user wants to join a group, he can either input the whole message (and you crop out the id) or only the id. This way the user can just press copy and insert.

GR0ZA commented 4 months ago

Ah I see 😅

  1. I think this would mean extra overhead but should be possible. However I'm not sure whether it's good UX. As a user I wouldn't expect that something gets copied to my clipboard when clicking this "add_person" icon, but rather only when the "copy" icon is clicked. But it's splitting hairs a little bit 😅
  2. Yeah we could do this. In the best case our next work on this is implementing deep links but we can do it before.

I'll create a new issue for both things, ok?

Morvvvv commented 4 months ago
  1. I thought you could ahve both, but you're choice, as this does not really matter.

Alright, in the best case, as you said, we will never implement this.