search

lab-64 / split-the-bill-client

Flutter App for easy and fast splitting up of receipts
4 stars 0 forks source link

98 group reset #128

Closed Morvvvv closed 4 months ago

Morvvvv commented 4 months ago

As always, for design changes just make an issue. :)

Closes #98

GR0ZA commented 4 months ago

Just a general thing: we have the issue for rewriting functions returning widgets (bad practice) into class widgets (here #58 ) You have some functions returning widgets in your code. Try to avoid this in the future, we'll then have less work :laughing: But don't change it here, it's fine.

GR0ZA commented 4 months ago

The files and widgets have a really good structure (transactions_screen, transactions_list, transaction_item, ...). I like it! Good job in general, just some smaller things to improve :) I think the UI is good and it works as it should

Morvvvv commented 4 months ago

You're correct about the issue for rewriting functions returning widgets. Totally forgot about that. I quickly tunred them into widgets.