search

lab-64 / split-the-bill-client

Flutter App for easy and fast splitting up of receipts
4 stars 0 forks source link

32: Display username & avatar #33

Closed GR0ZA closed 5 months ago

GR0ZA commented 5 months ago

Review #30 first please.

For testing:

Closes #32

Morvvvv commented 5 months ago

How do we deal with too long usernames? Cut into parts and put into seperate lines or maybe just a set length and "..."? In the moment it causes a pixel overflow in the homepage header, in the group page for bill creator. Other wrong functionality is for the contributors list, it cuts the last member off, because the user with the long username "pushes" it down. In groups members tab this only looks a bit weird. We can also put this as an issue, as everything works perfectly fine.

GR0ZA commented 5 months ago

How do we deal with too long usernames? Cut into parts and put into seperate lines or maybe just a set length and "..."? In the moment it causes a pixel overflow in the homepage header, in the group page for bill creator. Other wrong functionality is for the contributors list, it cuts the last member off, because the user with the long username "pushes" it down. In groups members tab this only looks a bit weird. We can also put this as an issue, as everything works perfectly fine.

Thanks for the feedback. Yeah right now we don't care about the length :smile: . I think setting a maximal length (on both backend & frontend) and ellipsizing with "..." is a nice solution. I'll create an issue for this. If everything else is fine you can merge the PR.