45 change price input - Githubissues

lab-64 / split-the-bill-client

Flutter App for easy and fast splitting up of receipts

4 stars 0 forks source link

Closed Morvvvv closed 2 months ago

Morvvvv commented 3 months ago

Please review #91 first.

Closes #45

GR0ZA commented 2 months ago

Removing the price and setting it again results in some range errors.

Morvvvv commented 2 months ago

I changed the behavior of digit deletion, so that it always deletes the most right digit and pushes the others 1 to the right.

GR0ZA commented 2 months ago

@Morvvvv It works nice. In case u wonder, I fixed two small issues:

you forgot to pass the onChanged from edit_item.dart to price_text_field.dart and call it in there after your processing. It's necessary to do that in order to update the underlying items. Without that all created items have the price of 0.
I added a regex rule that allows only numbers as input (on keyboard it was possible to type chars)