labscommunity / arweave-wallet-kit

A React library for interaction with different Arweave wallets
https://docs.arweavekit.com/wallets/wallet-kit
MIT License
19 stars 11 forks source link

added font to ThemeConfig interface including fontFamily #13

Closed heiningair closed 9 months ago

heiningair commented 10 months ago

for this first PR, I only added the font (Font interface) to the ThemeConfig which only holds the "fontFamily".

Please let me know if that suits you. Then I will go on with further enhancements, like making the ConnectButton text configurable, etc.

thx

heiningair commented 10 months ago

Thank you for your quick submission! To complete the PR, it should include a theme config font option in the Basic properties of the ConnectButton story for the Storybook

I checked in the fixes for the font's fontFamily to work properly and added the info about it in the markdown. Can you please point me to the right spot for what you meant exactly with the Storybook? I didnt really get what you are referring to here. Thank you

EDIT: I guess I just found it.. I'll add that in another commit! Let me know if something is still missing to complete this PR.

heiningair commented 9 months ago

@7i7o any updates on this one here?

7i7o commented 9 months ago

Hey @heiningair, I left you a final "requested changes" on the last review. If you want, I can do them myself before merging.

heiningair commented 9 months ago

Hey @heiningair, I left you a final "requested changes" on the last review. If you want, I can do them myself before merging.

@7i7o sorry for the inconveniece, but I can't find these final "requested changes" after my last fixing commits for the first requested changes. If you dont mind it would be great if you can review my latest commits and merge if everything is fine. Sorry again for me not being able to find that..

7i7o commented 9 months ago

@heiningair my bad. GH left my requested changes review in pending and didn't publish it 🤦 It's solved now and I'm merging the changes. We'll be publishing the package with the updates soon