laktak / zfind

search for files (even inside tar/zip/7z/rar) using a SQL-WHERE filter
MIT License
381 stars 4 forks source link

typos suggestion #6

Closed ccoVeille closed 3 months ago

ccoVeille commented 3 months ago
laktak commented 3 months ago

Thank you!

When you fixed "Use a a null character" you deleted both a's.

Also why mix ```shell and ```console?

ccoVeille commented 3 months ago

It refers to different block identifier types

Shell Session https://github.com/github-linguist/linguist/blob/42fd3c2514375fc6ad281552368edd3fb9f6ee7f/lib/linguist/languages.yml#L6697-L6708

Shell https://github.com/github-linguist/linguist/blob/42fd3c2514375fc6ad281552368edd3fb9f6ee7f/lib/linguist/languages.yml#L6610-L6684

You can look here

https://github.com/github-linguist/linguist/blob/42fd3c2514375fc6ad281552368edd3fb9f6ee7f/grammars.yml#L771-L773

Then here

https://github.com/github-linguist/linguist/tree/master/vendor/grammars

Then here

https://github.com/atom/language-shellscript/tree/35dc1aa1371ab75ece08fd0837330eb62e1f9da9/grammars

Then here https://github.com/atom/language-shellscript/blob/35dc1aa1371ab75ece08fd0837330eb62e1f9da9/grammars/shell-unix-bash.cson https://github.com/atom/language-shellscript/blob/35dc1aa1371ab75ece08fd0837330eb62e1f9da9/grammars/shell-session.cson

These are 2 distinct languages, shell session includes shell-unix

So the syntax rendering is different

```shell
# find files smaller than 10KB, in the current path
zfind 'size<10k'

# find files in the given range in /some/path
zfind 'size between 1M and 1G' /some/path

render this

```shell
# find files smaller than 10KB, in the current path
zfind 'size<10k'

# find files in the given range in /some/path
zfind 'size between 1M and 1G' /some/path
```console
# find files smaller than 10KB, in the current path
$ zfind 'size<10k'

# find files in the given range in /some/path
$ zfind 'size between 1M and 1G' /some/path

```console
# find files smaller than 10KB, in the current path
$ zfind 'size<10k'

# find files in the given range in /some/path
$ zfind 'size between 1M and 1G' /some/path

shell is used when there is only one command, and the result of the command is not provided console is used when there is the result of the command or multiple command, or comments, then a $ is almost always provided to distinct shell command from result

```console
$ pwd
/tmp

```console
$ pwd
/tmp
```shell
$ pwd
/tmp

```shell
$ pwd
/tmp
laktak commented 3 months ago

OK, thanks for the explanation! :)