search

lalitkumarthakur / javascripthelpbylalit

The Complete JavaScript Course 2023: From Zero to Expert! from udemy. Learning javascript using this course.
https://lalitkumarthakur.github.io/javascripthelpbylalit/
BSD 3-Clause "New" or "Revised" License
0 stars 2 forks source link

Js issues #90

Open VishalD51 opened 1 year ago

VishalD51 commented 1 year ago

Print 3rd array.

lalitkumarthakur commented 1 year ago

Please sync the latest changes at the time of comiting to avoid any conflicts @VishalD51

VishalD51 commented 1 year ago

Hi @VishalD51 , Thanks for requesting the PR as instructed. But there is a problem you did, and you have to face inconvenience for that, and I am sorry for that in advanced.

You have changes double inverted commas to single. And I don't like that fact. Please revert the changes and use "" commas through out the code.

I come from a Java Background, I don't want to use Single Inverted commas. I understand that different devs has different preferences, but please use as instructed because I have used double invited commas thought out the project.

Thanks.

@lalitkumarthakur Sorry for inconsistency, I will improve it and raise PR.

VishalD51 commented 1 year ago

@lalitkumarthakur , can you please check this PR?

lalitkumarthakur commented 11 months ago

Hi @VishalD51 , I do not see any activity from your side regarding this issue. Please clear me that "are you willing to contribute further? Or leave it from here itself?"

VishalD51 commented 11 months ago

@lalitkumarthakur, Yes I want to contribute further and also try solve other issues soon. I am busy with other priority projects. Sorry for that.

lalitkumarthakur commented 9 months ago

Hi @VishalD51 , There is no activity from your side. Please be a responsible contributor and complete the task which you have taken. Once the task is completed, then you are free to discontinue or stop contributing to this project.

lalitkumarthakur commented 3 months ago

Hi @VishalD51, there is no activity from your side from a long time. Do you want to contribute to this project and solve the issue?