search

lambdaclass / zksync_era_precompiles

Yul precompile library to speedup elliptic curves operations.
Apache License 2.0
51 stars 19 forks source link

28/36 Test EcAdd fail #223

Closed rdubois-crypto closed 8 months ago

rdubois-crypto commented 9 months ago

Tests are failing when launching the command

make test

It seems that some files might be missing to the repo (having tests working locally).

image

IAvecilla commented 8 months ago

Hey! Have you executed the era-test-node with make run-node in one terminal and then performed make test in another one? If so, please share the errors here to see better what's happening. However, it's expected to fail if the tests can't connect with the local node.

rdubois-crypto commented 8 months ago

Hi !

Actually the make run-node is failing. Most likely related to https://github.com/lambdaclass/zksync_era_precompiles/issues/225.

(So fixing it shall very likely solve this one)

rdubois-crypto commented 8 months ago

(Thx for the response)

rdubois-crypto commented 8 months ago

Those tests are now ok, according to last PR. However ecmul is still failing in some cases.

Closing this issue for a distinct one here: https://github.com/lambdaclass/zksync_era_precompiles/issues/232