lambdaclass / zksync_era_precompiles

Yul precompile library to speedup elliptic curves operations.
Apache License 2.0
51 stars 19 forks source link

Inaccurate `t` value in `NAF_REPRESENTATIVE()` doc comment #236

Closed IAvecilla closed 7 months ago

IAvecilla commented 7 months ago

Context: EcPairing.yul#L80

Description: Miller loop for ate pairing iterates to 6x+2 not to 6x^2 + 1. This value is trace of Frobenius not ate loop count.

Recommendation:

Update doc comment

zkSync:

Spearbit: