search

laphinisee / vocabbie

0 stars 0 forks source link

translate API already includes detect language functionality #2

Open CloudApiStudy opened 4 years ago

CloudApiStudy commented 4 years ago

Hi,

I come from a research team which works on bugs in real-world applications.

I want to make a report about a potential performance improvement in your project.

In file (src/nlp/nlpMain.js), you call both detect dominate language and translate API on the same text. However, the translate API will automatically detect the input language and return it as one of the output attribute. By skipping detect dominate language call, the execution time could reduce around 20%.

Perhaps someone might be able to confirm if these seem reasonable. Also, if so, the fix seems like it would be pretty straightforward, and I’m happy to create a pull request if that will be helpful.

If you are not offended by it, we may include your response as a percentage number (e.g. xx% of applications faces xx problem, and xx% of them confirms it) in our research paper.

Thanks.

lucyhyw commented 4 years ago

Hi there. Thanks for reaching out. This code was written for a class project two years ago, so we're unlikely to look into the issue ourselves. Happy to approve a pull request if you're making one, but it's not necessary by any means. And happy to be included as a stat.

On Sun, Aug 16, 2020, 10:42 AM C Wan notifications@github.com wrote:

Hi,

I come from a research team in University of Chicago, which works on bugs in real-world applications.

I want to make a report about a potential performance improvement in your project.

In file (src/nlp/nlpMain.js ), you call both detect dominate language and translate API on the same text. However, the translate API will automatically detect the input language and return it as one of the output attribute. By skipping detect dominate language call, the execution time could reduce around 20%.

Perhaps someone might be able to confirm if these seem reasonable. Also, if so, the fix seems like it would be pretty straightforward, and I’m happy to create a pull request if that will be helpful.

If you are not offended by it, we may include your response as a percentage number (e.g. xx% of applications faces xx problem, and xx% of them confirms it) in our research paper.

Thanks.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/laphinisee/vocabbie/issues/2, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABHC7N2H6MUZVR2RXK6WETDSA7V6TANCNFSM4QA3R67A .

CloudApiStudy commented 4 years ago

Thanks so much for your reply!