larkinds / Spotify.MLH

3 stars 1 forks source link

Login within Bottom Bar / VsCode #22

Open larkinds opened 3 years ago

larkinds commented 3 years ago

Keep entire authentication process within VScode

jkmartindale commented 3 years ago

If I remember our conversation correctly from yesterday, this goal is to open a pop-up login window inside of VS Code instead of in a web browser. I just realized that the browser has a few advantages:

A lot of user preference lives in the browser. We lose all of these advantages once we pop a webview in VS Code instead.

The main issue with browser auth, the ugly success page, is fixed by #26, so this issue isn't as necessary anyway.

jkmartindale commented 3 years ago

Then again, Karan suggested this during pod demos today. So maybe this is something that users would expect anyway, and I'm wrong to think user preference is the browser.