search

lasconic / finary_uapi

MIT License
38 stars 11 forks source link

handling currency for UI display + real estate #138

Closed nmathey closed 1 year ago

nmathey commented 1 year ago

In response to #137 Include also the fix from #136

@lasconic let me know if you want handle currency as proposed in finary_uapi or if you prefer from a client application instead.

nmathey commented 1 year ago

I'm lost trying figuring out the quality check failure :( If you can help me :)

lasconic commented 1 year ago

For quality check, run

poetry install `(if you didn't do it yet)`
poetry shell
./check.sh
nmathey commented 1 year ago

@lasconic while reading again your comment, the workaround for the real estate functions is actually already a sort of "application manipulation" . I can propose you to remove the real estate functions modification from this PR but keep the new change display currency function since it is pure API call?

Let me know.

lasconic commented 1 year ago

@nmathey can you check https://github.com/lasconic/finary_uapi/pull/143 ? Does it suit your needs ?