search

lavolp3 / MMM-AVStock

MagicMirror module for displaying stock price with Alphavantage API
MIT License
38 stars 18 forks source link

performance can now also be displayed relatively #39

Closed spitzlbergerj closed 3 years ago

spitzlbergerj commented 3 years ago

Option showPerformanceAbsolute introduced. If this is true, a 20% increase in value is displayed as 120% (purchase price 100 EUR, current price 120 EUR). By default this increase is now displayed as 20%.

lavolp3 commented 3 years ago

Thanks for the input, much appreciated, but I have to say a have thrown this around in the meantime locally. I might need to reject your PR because your input has moved in the code already. Let me check. Sorry if I created unnecessary work.

spitzlbergerj commented 3 years ago

Hi, sure, if this is already included, then throw the pull request away. But first I pull the latest code from master and tried it. Unfortunately it didn't work correctly, so I updated the code for the performance display and added the option to choose how the performance should be displayed.

lavolp3 commented 3 years ago

Yeah you couldnt test the code yet because it's still local. Will upgrade master soon to 2.3.0 and then have a look at your PR.

spitzlbergerj commented 3 years ago

Thanks for integrate