lavolp3 / MMM-AVStock

MagicMirror module for displaying stock price with Alphavantage API
MIT License
38 stars 18 forks source link

Yahoo Finance should be updated again #76

Closed leeschmalz closed 1 month ago

leeschmalz commented 1 month ago

this api call fails with the current version: stock.quotes = await yfinance2.quoteSummary(symbols[i], {modules: ['price']});

should be updated to version 2.11.3

see discussion: https://github.com/gadicc/node-yahoo-finance2/issues/764

lavolp3 commented 1 month ago

I have pushed a force to yfinance2 api v. 2.11.3

Please update:

git pull
npm install

and let me know if it works.

Thanks!

leeschmalz commented 1 month ago

I am running master branch, updating locally to 2.11.3 worked for me. it looks like your push was to "yfinance" branch, which contains other changes that I have not tested.

rmcelwee commented 1 month ago

This did NOT fix it for me: git pull npm install

This DID fix it. Thanks again for a great module and the help to keep it running! rm -r node_modules rm package-lock.json git pull npm install

jmslln commented 1 month ago

I was seeing this in the log: _[2024-06-05 12:56:33.703] [LOG] MMM-AVStock: Error: Unsupported redirect to https://finance.yahoo.com/quote/AAPL/, please report. at /home/pi/MagicMirror/modules/MMM-AVStock/node_modules/yahoo-finance2/dist/cjs/src/lib/getCrumb.js:103:23 at Generator.next () at fulfilled (/home/pi/MagicMirror/modules/MMM-AVStock/node_modules/yahoo-finance2/dist/cjs/src/lib/getCrumb.js:5:58) at process.processTicksAndRejections (node:internal/process/taskqueues:95:5)

the advice from rmcelwee worked for me - thanks to both of you for keeping this module active

lavolp3 commented 1 month ago

I am running master branch, updating locally to 2.11.3 worked for me. it looks like your push was to "yfinance" branch, which contains other changes that I have not tested.

This is right. I need to push the yfinance branch then it works how I described. Will do this tonight.

lavolp3 commented 1 month ago

2 weeks late but has been pushed now. Closing this as resolved.